You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Lam nguyen phuc <ru...@gmail.com> on 2012/11/13 05:08:20 UTC

Code refactoring in NumberUtils

Hi,

There are a few redundant pieces of code in NumberUtils which should be
removed. Attached is the diff file after doing refactoring. Note that all
test cases for NumberUtils still pass successfully with this change of code.

Regards,
Harry

Re: Code refactoring in NumberUtils

Posted by Lam nguyen phuc <ru...@gmail.com>.
Jira has been created at https://issues.apache.org/jira/browse/LANG-856.

Regards,
Harry


On Tue, Nov 13, 2012 at 1:17 PM, Gary Gregory <ga...@gmail.com>wrote:

> Please create a Jira and attach your patch there.
>
> Thank you,
> Gary
>
> On Nov 12, 2012, at 23:08, Lam nguyen phuc <ru...@gmail.com> wrote:
>
> > Hi,
> >
> > There are a few redundant pieces of code in NumberUtils which should be
> removed. Attached is the diff file after doing refactoring. Note that all
> test cases for NumberUtils still pass successfully with this change of code.
> >
> > Regards,
> > Harry
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Re: Code refactoring in NumberUtils

Posted by Gary Gregory <ga...@gmail.com>.
Please create a Jira and attach your patch there.

Thank you,
Gary

On Nov 12, 2012, at 23:08, Lam nguyen phuc <ru...@gmail.com> wrote:

> Hi,
>
> There are a few redundant pieces of code in NumberUtils which should be removed. Attached is the diff file after doing refactoring. Note that all test cases for NumberUtils still pass successfully with this change of code.
>
> Regards,
> Harry
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org