You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/16 08:33:49 UTC
[GitHub] [spark] MaxGekk opened a new pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
MaxGekk opened a new pull request #30385:
URL: https://github.com/apache/spark/pull/30385
### What changes were proposed in this pull request?
Replace `spark.sql.sources.write.useV1SourceList` by `spark.sql.sources.useV1SourceList` in the comment for `CatalogManager.v2SessionCatalog()`.
### Why are the changes needed?
To have correct comments.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running `./dev/scalastyle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30385:
URL: https://github.com/apache/spark/pull/30385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-728013070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727847098
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35748/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727825347
**[Test build #131145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131145/testReport)** for PR 30385 at commit [`a0d35b0`](https://github.com/apache/spark/commit/a0d35b0359e424dd47844129e88caa936043a88c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-728008867
**[Test build #131145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131145/testReport)** for PR 30385 at commit [`a0d35b0`](https://github.com/apache/spark/commit/a0d35b0359e424dd47844129e88caa936043a88c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727836179
Relevant test such as linter and compilation passed. Let me just merge this in. Seems like it's from SPARK-28747. I will merge it to branch-3.0 too.
Merged to master and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727847086
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727847086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #30385:
URL: https://github.com/apache/spark/pull/30385#discussion_r523970602
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala
##########
@@ -78,7 +78,7 @@ class CatalogManager(
* This catalog is a v2 catalog that delegates to the v1 session catalog. it is used when the
* session catalog is responsible for an identifier, but the source requires the v2 catalog API.
* This happens when the source implementation extends the v2 TableProvider API and is not listed
- * in the fallback configuration, spark.sql.sources.write.useV1SourceList
+ * in the fallback configuration, spark.sql.sources.useV1SourceList
Review comment:
https://github.com/apache/spark/blob/234711a328dd4cd888d6a73145984987eabc483b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L2071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-728013070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30385: [MINOR][SQL][DOCS] Fix a reference to `spark.sql.sources.useV1SourceList`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30385:
URL: https://github.com/apache/spark/pull/30385#issuecomment-727825347
**[Test build #131145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131145/testReport)** for PR 30385 at commit [`a0d35b0`](https://github.com/apache/spark/commit/a0d35b0359e424dd47844129e88caa936043a88c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org