You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by Graham Charters <gc...@googlemail.com> on 2010/03/09 22:15:43 UTC

Re: svn commit: r920898 - in /incubator/aries/trunk: ./ eba-maven-plugin/ maven-eba-plugin/ maven-eba-plugin/src/it/default/ maven-eba-plugin/src/main/resources/META-INF/plexus/ maven-eba-plugin/src/test/resources/unit/basic-eba-test/ maven-eba-plugi

I did wonder, but there are so many examples which follow the
maven-xxx-plugin, that aren't 'official'.  Tuscany has 7, for example
:-S .  I had a quick hunt for guidance and found the following link:
http://maven.apache.org/guides/plugin/guide-java-plugin-development.html
.  It describes how to create the maven-hello-plugin (using their
convention) and it states the following which suggests both naming
styles are 'official' but doesn't say they should be avoided.

"The "maven-$name-plugin" and "$name-maven-plugin" artifactId patterns
are treated in a special way. If no plugin matches the artifactId
specified on the command line, Maven will try expanding the artifactId
to these patterns in that order. So in the case of our example, you
can use "mvn sample.plugin:hello:sayhi" to run your plugin. Note:
these 2 patterns are used respectively by the official Maven 2 plugins
and the Mojo project plugins."

Can you point me at some guidance to make sure we don't end up with
multiple renames?

Many thanks.

Graham.

On 9 March 2010 18:38, David Jencks <da...@yahoo.com> wrote:
> Please undo this, it is contrary to the naming policy maven is trying to get
> people to use.  Only plugins maintained by the maven project are supposed to
> be named maven-foo-plugin.
>
> thanks
> david jencks
>
> On Mar 9, 2010, at 6:45 AM, gcc@apache.org wrote:
>
>> Author: gcc
>> Date: Tue Mar  9 14:45:46 2010
>> New Revision: 920898
>>
>> URL: http://svn.apache.org/viewvc?rev=920898&view=rev
>> Log:
>> ARIES-230
>> Renamed eba-maven-plugin to maven-eba-plugin for consistency with other
>> plugins.
>> Also updated poms for samples to use the new plugin.
>>
>> Added:
>>   incubator/aries/trunk/maven-eba-plugin/
>>     - copied from r920879, incubator/aries/trunk/eba-maven-plugin/
>> Removed:
>>   incubator/aries/trunk/eba-maven-plugin/
>> Modified:
>>   incubator/aries/trunk/maven-eba-plugin/pom.xml
>>   incubator/aries/trunk/maven-eba-plugin/src/it/default/pom.xml
>>
>> incubator/aries/trunk/maven-eba-plugin/src/main/resources/META-INF/plexus/components.xml
>>
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-test/plugin-config.xml
>>
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-descriptor/plugin-config.xml
>>
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-manifest/plugin-config.xml
>>   incubator/aries/trunk/pom.xml
>>
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-all-eba/pom.xml
>>
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-jdbc-eba/pom.xml
>>   incubator/aries/trunk/samples/blog/blog-jdbc-eba/pom.xml
>>   incubator/aries/trunk/samples/blog/blog-jpa-eba/pom.xml
>>
>> Modified: incubator/aries/trunk/maven-eba-plugin/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/pom.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/maven-eba-plugin/pom.xml (original)
>> +++ incubator/aries/trunk/maven-eba-plugin/pom.xml Tue Mar  9 14:45:46
>> 2010
>> @@ -30,18 +30,18 @@ under the License.
>>        <version>0.1-incubating-SNAPSHOT</version>
>>    </parent>
>>
>> -    <artifactId>eba-maven-plugin</artifactId>
>> +    <artifactId>maven-eba-plugin</artifactId>
>>    <version>0.1-incubating-SNAPSHOT</version>
>>    <packaging>maven-plugin</packaging>
>>
>> -    <name>Aries EBA Maven Plugin</name>
>> +    <name>Aries Maven EBA Plugin</name>
>>    <description>Builds an eba (Enterprise Bundle Archive) from the project
>> for deployment to an aries server.
>>    </description>
>>
>>    <scm>
>> -
>>  <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/aries/trunk/eba-maven-plugin</connection>
>> -
>>  <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/aries/trunk/eba-maven-plugin</developerConnection>
>> -
>>  <url>http://svn.apache.org/viewvc/incubator/aries/trunk/eba-maven-plugin</url>
>> +
>>  <connection>scm:svn:http://svn.apache.org/repos/asf/incubator/aries/trunk/maven-eba-plugin</connection>
>> +
>>  <developerConnection>scm:svn:https://svn.apache.org/repos/asf/incubator/aries/trunk/maven-eba-plugin</developerConnection>
>> +
>>  <url>http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin</url>
>>    </scm>
>>
>>    <dependencies>
>>
>> Modified: incubator/aries/trunk/maven-eba-plugin/src/it/default/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/src/it/default/pom.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/maven-eba-plugin/src/it/default/pom.xml
>> (original)
>> +++ incubator/aries/trunk/maven-eba-plugin/src/it/default/pom.xml Tue Mar
>>  9 14:45:46 2010
>> @@ -34,7 +34,7 @@ under the License.
>>        <plugins>
>>            <plugin>
>>                <groupId>org.apache.aries.application</groupId>
>> -                <artifactId>eba-maven-plugin</artifactId>
>> +                <artifactId>maven-eba-plugin</artifactId>
>>                <version>@project.version@</version>
>>                <extensions>true</extensions>
>>                <configuration>
>>
>> Modified:
>> incubator/aries/trunk/maven-eba-plugin/src/main/resources/META-INF/plexus/components.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/src/main/resources/META-INF/plexus/components.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/maven-eba-plugin/src/main/resources/META-INF/plexus/components.xml
>> (original)
>> +++
>> incubator/aries/trunk/maven-eba-plugin/src/main/resources/META-INF/plexus/components.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -38,7 +38,7 @@
>>                          </process-test-resources>
>>
>>  <test-compile>org.apache.maven.plugins:maven-compiler-plugin:testCompile</test-compile>
>>
>>  <test>org.apache.maven.plugins:maven-surefire-plugin:test</test>
>> -
>>  <package>org.apache.aries:eba-maven-plugin:eba</package>
>> +
>>  <package>org.apache.aries:maven-eba-plugin:eba</package>
>>
>>  <install>org.apache.maven.plugins:maven-install-plugin:install</install>
>>
>>  <deploy>org.apache.maven.plugins:maven-deploy-plugin:deploy</deploy>
>>                        </phases>
>>
>> Modified:
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-test/plugin-config.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-test/plugin-config.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-test/plugin-config.xml
>> (original)
>> +++
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-test/plugin-config.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -21,7 +21,7 @@ under the License.
>>  <build>
>>    <plugins>
>>      <plugin>
>> -        <artifactId>eba-maven-plugin</artifactId>
>> +        <artifactId>maven-eba-plugin</artifactId>
>>                <configuration>
>>
>>  <ebaSourceDirectory>${basedir}/src/test/resources/unit/basic-eba-test/src/main/eba</ebaSourceDirectory>
>>
>>  <applicationManifestFile>${basedir}/src/test/resources/unit/basic-eba-test/src/main/eba/META-INF/application.mf</applicationManifestFile>
>>
>> Modified:
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-descriptor/plugin-config.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-descriptor/plugin-config.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-descriptor/plugin-config.xml
>> (original)
>> +++
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-descriptor/plugin-config.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -21,7 +21,7 @@ under the License.
>>  <build>
>>    <plugins>
>>      <plugin>
>> -        <artifactId>eba-maven-plugin</artifactId>
>> +        <artifactId>maven-eba-plugin</artifactId>
>>                <configuration>
>>
>>  <ebaSourceDirectory>${basedir}/src/test/resources/unit/basic-eba-with-descriptor/src/main/eba</ebaSourceDirectory>
>>
>>  <applicationManifestFile>${basedir}/src/test/resources/unit/basic-eba-with-descriptor/src/main/eba/META-INF/application.mf</applicationManifestFile>
>>
>> Modified:
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-manifest/plugin-config.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-manifest/plugin-config.xml?rev=920898&r1=920879&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-manifest/plugin-config.xml
>> (original)
>> +++
>> incubator/aries/trunk/maven-eba-plugin/src/test/resources/unit/basic-eba-with-manifest/plugin-config.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -21,7 +21,7 @@ under the License.
>>  <build>
>>    <plugins>
>>      <plugin>
>> -        <artifactId>eba-maven-plugin</artifactId>
>> +        <artifactId>maven-eba-plugin</artifactId>
>>                <configuration>
>>
>>  <ebaSourceDirectory>${basedir}/src/test/resources/unit/basic-eba-with-manifest/src/main/eba</ebaSourceDirectory>
>>
>>  <applicationManifestFile>${basedir}/src/test/resources/unit/basic-eba-with-manifest/src/main/eba/META-INF/application.mf</applicationManifestFile>
>>
>> Modified: incubator/aries/trunk/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/pom.xml?rev=920898&r1=920897&r2=920898&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/pom.xml (original)
>> +++ incubator/aries/trunk/pom.xml Tue Mar  9 14:45:46 2010
>> @@ -38,7 +38,7 @@
>>
>>    <modules>
>>        <module>parent</module>
>> -        <module>eba-maven-plugin</module>
>> +        <module>maven-eba-plugin</module>
>>        <module>testsupport</module>
>>        <module>util</module>
>>        <module>blueprint</module>
>>
>> Modified:
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-all-eba/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-all-eba/pom.xml?rev=920898&r1=920897&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-all-eba/pom.xml
>> (original)
>> +++
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-all-eba/pom.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -74,11 +74,8 @@
>>        <plugins>
>>            <plugin>
>>                <groupId>org.apache.aries</groupId>
>> -                <artifactId>eba-maven-plugin</artifactId>
>> +                <artifactId>maven-eba-plugin</artifactId>
>>                <extensions>true</extensions>
>> -                <configuration>
>> -                    <includeJar>false</includeJar>
>> -                </configuration>
>>            </plugin>
>>        </plugins>
>>    </build>
>>
>> Modified:
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-jdbc-eba/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-jdbc-eba/pom.xml?rev=920898&r1=920897&r2=920898&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-jdbc-eba/pom.xml
>> (original)
>> +++
>> incubator/aries/trunk/samples/ariestrader-sample/assemblies/ariestrader-jdbc-eba/pom.xml
>> Tue Mar  9 14:45:46 2010
>> @@ -62,11 +62,8 @@
>>        <plugins>
>>            <plugin>
>>                <groupId>org.apache.aries</groupId>
>> -                <artifactId>eba-maven-plugin</artifactId>
>> +                <artifactId>maven-eba-plugin</artifactId>
>>                <extensions>true</extensions>
>> -                <configuration>
>> -                    <includeJar>false</includeJar>
>> -                </configuration>
>>            </plugin>
>>        </plugins>
>>    </build>
>>
>> Modified: incubator/aries/trunk/samples/blog/blog-jdbc-eba/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/blog/blog-jdbc-eba/pom.xml?rev=920898&r1=920897&r2=920898&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/samples/blog/blog-jdbc-eba/pom.xml (original)
>> +++ incubator/aries/trunk/samples/blog/blog-jdbc-eba/pom.xml Tue Mar  9
>> 14:45:46 2010
>> @@ -67,7 +67,7 @@ under the License.
>>        <plugins>
>>            <plugin>
>>                <groupId>org.apache.aries</groupId>
>> -                <artifactId>eba-maven-plugin</artifactId>
>> +                <artifactId>maven-eba-plugin</artifactId>
>>                <version>${version}</version>
>>                <extensions>true</extensions>
>>                <configuration>
>>
>> Modified: incubator/aries/trunk/samples/blog/blog-jpa-eba/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/blog/blog-jpa-eba/pom.xml?rev=920898&r1=920897&r2=920898&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/samples/blog/blog-jpa-eba/pom.xml (original)
>> +++ incubator/aries/trunk/samples/blog/blog-jpa-eba/pom.xml Tue Mar  9
>> 14:45:46 2010
>> @@ -67,7 +67,7 @@ under the License.
>>        <plugins>
>>            <plugin>
>>                <groupId>org.apache.aries</groupId>
>> -                <artifactId>eba-maven-plugin</artifactId>
>> +                <artifactId>maven-eba-plugin</artifactId>
>>                <version>${version}</version>
>>                <extensions>true</extensions>
>>                <configuration>
>>
>>
>
>