You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wzhfy <gi...@git.apache.org> on 2017/05/10 07:11:59 UTC

[GitHub] spark pull request #16677: [SPARK-19355][SQL] Use map output statistices to ...

Github user wzhfy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16677#discussion_r115642947
  
    --- Diff: core/src/main/scala/org/apache/spark/MapOutputStatistics.scala ---
    @@ -23,5 +23,9 @@ package org.apache.spark
      * @param shuffleId ID of the shuffle
      * @param bytesByPartitionId approximate number of output bytes for each map output partition
      *   (may be inexact due to use of compressed map statuses)
    + * @param numberOfOutput number of output for each pre-map output partition
    --- End diff --
    
    What does pre-map output partition mean? `numberOfOutput` is the same name in `MapStatus`, rename it `recordsByPartitionId`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org