You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/10/22 03:07:24 UTC

[GitHub] spark pull request #17100: [SPARK-13947][SQL] PySpark DataFrames: The error ...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17100#discussion_r146120797
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -270,12 +273,25 @@ trait CheckAnalysis extends PredicateHelper {
     
             operator match {
               case o if o.children.nonEmpty && o.missingInput.nonEmpty =>
    +            val resolver = conf.resolver
    --- End diff --
    
    We do not need to pass conf now. You can directly call `plan.conf.resolver`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org