You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gtully <gi...@git.apache.org> on 2018/01/24 14:21:51 UTC
[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...
GitHub user gtully opened a pull request:
https://github.com/apache/activemq-artemis/pull/1815
[ARTEMIS-1030] document url escaping of the virtualTopicConsumerWildc…
…ards value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtully/activemq-artemis ARTEMIS-1030
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1815.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1815
----
commit 23b3401bb067fa9f2d66e418a2b4e245dc8177e4
Author: gtully <ga...@...>
Date: 2018-01-24T14:20:05Z
[ARTEMIS-1030] document url escaping of the virtualTopicConsumerWildcards value
----
---
[GitHub] activemq-artemis issue #1815: [ARTEMIS-1030] document url escaping of the vi...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1815
obviously the test failure has nothing to do with this PR. I'm going to merge this.
---
[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1815
---
[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...
Posted by gtully <gi...@git.apache.org>.
Github user gtully commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1815#discussion_r165010374
--- Diff: docs/user-manual/en/protocols-interoperability.md ---
@@ -215,9 +215,11 @@ The first is the 5.x style destination filter that identifies the destination as
The second identifies the number of ```paths``` that identify the consumer queue such that it can be parsed from the
destination.
For example, the default 5.x virtual topic with consumer prefix of ```Consumer.*.```, would require a
-```virtualTopicConsumerWildcards``` filter of:
+```virtualTopicConsumerWildcards``` filter of ```Consumer.*.>;2```. As url parameter this transforms to ```Consumer.*.%3E%3B2``` when
+the url significant characters ```;,``` are escaped with their hex code points.
--- End diff --
good catch howard, it should be. will update. thanks.
---
[GitHub] activemq-artemis pull request #1815: [ARTEMIS-1030] document url escaping of...
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1815#discussion_r164944682
--- Diff: docs/user-manual/en/protocols-interoperability.md ---
@@ -215,9 +215,11 @@ The first is the 5.x style destination filter that identifies the destination as
The second identifies the number of ```paths``` that identify the consumer queue such that it can be parsed from the
destination.
For example, the default 5.x virtual topic with consumer prefix of ```Consumer.*.```, would require a
-```virtualTopicConsumerWildcards``` filter of:
+```virtualTopicConsumerWildcards``` filter of ```Consumer.*.>;2```. As url parameter this transforms to ```Consumer.*.%3E%3B2``` when
+the url significant characters ```;,``` are escaped with their hex code points.
--- End diff --
should there be ```>;``` instead of ```;,```?
---