You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "vikasprabhakar (GitHub)" <gi...@apache.org> on 2018/08/27 10:08:22 UTC
[GitHub] [incubator-netbeans] vikasprabhakar opened pull request
#799: [NETBEANS-1074] Module Review web.jsf12
Add license in binary-list
update license in jsf-1.2-license.txt
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] matthiasblaesing commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "matthiasblaesing (GitHub)" <gi...@apache.org>.
You are changing the filename and this in turn means, that you need to adjust the `project.xml`, as that file references the file. In this case, I would not change the filename, as the important version information is coded into the subdirectory.
The `project.xml` is also missing the `binary-origin` header (that was the case already before your changes), please also add it (see `libs.amazon/nbproject/project.xml` for an example.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] asfgit closed pull request #799:
[NETBEANS-1074] Module Review web.jsf12
Posted by "asfgit (GitHub)" <gi...@apache.org>.
[ pull request closed by asfgit ]
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] vikasprabhakar commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.
@matthiasblaesing The following jars of web.jsf12 module are used in web.jsf12ri module
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-beanutils.jar=modules/ext/jsf-1_2/commons-beanutils.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-collections.jar=modules/ext/jsf-1_2/commons-collections.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-digester.jar=modules/ext/jsf-1_2/commons-digester.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-logging.jar=modules/ext/jsf-1_2/commons-logging.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/jsf-impl.jar=modules/ext/jsf-1_2/jsf-impl.jar
Could you provide the license details of following jar files so that I can add jar files in web.jsf12/external folder?
1. commons-beanutils.jar
2. commons-collections.jar
3. commons-digester.jar
4. jsf-impl.jar
Please provide the correct version of these jar files.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] vikasprabhakar commented on issue #799:
[NETBEANS-1074] Module Review web.jsf12
Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.
@matthiasblaesing It seems fine. Please merge the changes.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] vikasprabhakar commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.
@matthiasblaesing Added jar file name in project.xml .
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] matthiasblaesing commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "matthiasblaesing (GitHub)" <gi...@apache.org>.
Sorry this won't work (in this case). The file is directly referenced from other modules. I see references in java.project.ui, projectimport.eclipse.core, web.jsf.navigation, web.jsf12ri. I would change this to:
`release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api.jar`
Then the change in project.xml can be reverted, and from the outside nothing changes.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] junichi11 commented on pull request
#799: [NETBEANS-1074] Module Review web.jsf12
Posted by "junichi11 (GitHub)" <gi...@apache.org>.
@matthiasblaesing Thanks!
@vikasprabhakar Could you please fix them? Please see the Matthias' comment.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] matthiasblaesing commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "matthiasblaesing (GitHub)" <gi...@apache.org>.
This is not CDDL-1.0, but CDDL-1.1 -- the CDDL-1.0 file in `nbbuild/licenses/CDDL-1.0` is not correct. See my changeset here: https://github.com/apache/incubator-netbeans/pull/807/commits/ba70c38b946d16231082d3b861acfe6aa9606117
Please wait till that PR is merged, so that we ca correctly handle this.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] junichi11 commented on pull request
#799: [NETBEANS-1074] Module Review web.jsf12
Posted by "junichi11 (GitHub)" <gi...@apache.org>.
Maybe, download jsf-api.jar from [Maven Central](https://mvnrepository.com/artifact/javax.faces/jsf-api/1.2) ? It seems that the module uses it only.
https://github.com/apache/incubator-netbeans/blob/26cd220e505b04448d77a054ed6d7d29cf420120/web.jsf12/nbproject/project.properties#L18-L26
#### binaries-list
```
224B0C2CCA97240305DE96B3108D2E7397FBFC4D javax.faces:jsf-api:1.2
```
#### project.properties
```
release.external/jsf-api-1.2.jar=modules/ext/jsf-1_2/jsf-api.jar
```
@matthiasblaesing Is this correct?
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] matthiasblaesing commented on issue
#799: [NETBEANS-1074] Module Review web.jsf12
Posted by "matthiasblaesing (GitHub)" <gi...@apache.org>.
Ok - I had another look at it. This is my result:
https://github.com/matthiasblaesing/incubator-netbeans/commit/55b390687a94003eb85d170453b1461ea4f5d41a
That commit:
- restores the original file name of API jar to `jsf-api.jar`
- add `binary-origin` to the `class-path-extension` elements
- add separate RI download was added to `web.jsf12ri`
- the additional libraries (commons*) are removed, as `jdeps` does not report any dependencies on `org.apache` packages (apart from Tomcat integration). I assume they were necessary in the past
- the shaded apache beanutils, collections and digester packages are not present in the 1.2_05 version of the RI, so their package export is adjusted accordingly
- the maven dependencies are modified to match the referenced libraries
What do you think?
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] vikasprabhakar commented on issue #799:
[NETBEANS-1074] Module Review web.jsf12
Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.
@matthiasblaesing License details added from "harness/apisupport.harness/external/harness-launchers-8.2-license.txt"
Please review it.
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] vikasprabhakar commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "vikasprabhakar (GitHub)" <gi...@apache.org>.
@matthiasblaesing The following jars of web.jsf12 module are used in web.jsf12ri module
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-beanutils.jar=modules/ext/jsf-1_2/commons-beanutils.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-collections.jar=modules/ext/jsf-1_2/commons-collections.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-digester.jar=modules/ext/jsf-1_2/commons-digester.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/commons-logging.jar=modules/ext/jsf-1_2/commons-logging.jar
release.../web.jsf12/external/jsf-1.2.zip!/jsf-1.2/jsf-impl.jar=modules/ext/jsf-1_2/jsf-impl.jar
Could you provide the license details of following jar files so that I can add jar files in web.jsf12/external folder?
1. commons-beanutils.jar
2. commons-collections.jar
3. commons-digester.jar
4. jsf-impl.jar
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-netbeans] matthiasblaesing commented on pull
request #799: [NETBEANS-1074] Module Review web.jsf12
Posted by "matthiasblaesing (GitHub)" <gi...@apache.org>.
Hm - its a pitty - nearly every build of the jsf-1.2 API is present on maven central, but not the version (1.2_04-b20-p03) i the referenced jar. However from my experience the APIs are pretty stable, so I would tage the next bugfix revision: https://search.maven.org/artifact/javax.faces/jsf-api/1.2_05/jar.
That would mean, that the license file needs to be updated. For the project.properties I would remove lines 18-21 and lines 23-26. They look superflous and wrong (the API is not AL licensed).
[ Full content available at: https://github.com/apache/incubator-netbeans/pull/799 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org