You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/04 15:54:16 UTC
[GitHub] [airflow] ashb opened a new pull request #12092: Convert OpenAPI client generation tests to use selective checks
ashb opened a new pull request #12092:
URL: https://github.com/apache/airflow/pull/12092
This test was bundled in with the existing needs-api tests, but then
performed it's _own_ checks on if it should run. This changes that to
have selective_ci_checks.sh do this check.
Additionally CI_SOURCE_REPO was often wrong -- at least for me as I
don't open PRs from ashb/airflow, and this lead to a confusing message:
> https://github.com/ashb/airflow.git Branch my_branch does not exist
But all we were using this for was to find the "parent" commit, but
there is any easier way we can do that: HEAD^1 with a fetch depth of 2
to the checkout option.
So I've removed calculating that and where it is used.
If we need to bring it back we should use the output from the
`potiuk/get-workflow-origin` action -- that gets the correct value
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12092: Convert OpenAPI client generation tests to use selective checks
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12092:
URL: https://github.com/apache/airflow/pull/12092#issuecomment-721814981
/cc @ryanahamilton This should remove that confusing log message we saw in the CI logs yesterday that threw us off track.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12092: Convert OpenAPI client generation tests to use selective checks
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12092:
URL: https://github.com/apache/airflow/pull/12092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12092: Convert OpenAPI client generation tests to use selective checks
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12092:
URL: https://github.com/apache/airflow/pull/12092#issuecomment-722430450
Yeah, I remember you somewhere talking about ^1 etc and tested it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12092: Convert OpenAPI client generation tests to use selective checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12092:
URL: https://github.com/apache/airflow/pull/12092#issuecomment-722313958
:tada:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12092: Convert OpenAPI client generation tests to use selective checks
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12092:
URL: https://github.com/apache/airflow/pull/12092#issuecomment-722313601
Very good change indeed. I was thinking about getting rid of it and as of recently (when we added CodeQL workflow following the documentation of Github, we realized that we can use HEAD^1 and fetch depth to achieve this and we already used in several new actions that we developed with Tobiasz. The learning we had was that we can rely on HEAD^1 being the "target" of the merge, because it could be either HEAD^1 or HEAD^2 in merge requests, depends which is the direction of the merge performed by GitHub.
But since they are using it in their own actions (for CodeQL to determine the head of PR) https://github.com/github/codeql-action we've learned we can rely on it.
This was not obvious as Github does not explain how they are doing the merges and the CI_SOURCE_REPO etc is I think the last remnant of Travis (it was initially implemented there as their merging strategy was much different than the GitHub one).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org