You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/23 06:31:23 UTC

[GitHub] [dubbo-go-hessian2] zhangymPerson opened a new pull request #256: Fixes #232 Add go struct refer to java.util.UUID 

zhangymPerson opened a new pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256


   <!--  Thanks for sending a pull request! 
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-797168328


   
   > @zhangymPerson can u add another unit test , which check whether the uuid string generated by java is equal to that generated by golang ?
   
   @zhangymPerson  maybe u do not got what I means, u response uuid string like the following and check whether it's equal to `&java_util.UUID{LeastSigBits: int64(-7160773830801198154), MostSigBits: int64(459021424248441700)}.ToString()`
   
   ```java
       public static String javautilUUIDString() {
           UUID uuid = new UUID(459021424248441700L, -7160773830801198154L);
           return uuid.toString();
       }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#discussion_r570189465



##########
File path: java_util/UUID.go
##########
@@ -0,0 +1,71 @@
+/*

Review comment:
       pls  rename this file to uuid.go

##########
File path: java_util/UUID_test.go
##########
@@ -0,0 +1,49 @@
+/*

Review comment:
       pls  rename this file to uuid_test.go




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#discussion_r565109216



##########
File path: .travis.yml
##########
@@ -1,32 +1,16 @@
 language: go
 
-jobs:

Review comment:
       why remove jdk？

##########
File path: .travis.yml
##########
@@ -1,32 +1,16 @@
 language: go
 
-jobs:
-  include:
-    - language: java
-      jdk: openjdk8
-
 go:
+  - "1.11"
   - "1.12"
 
-os: linux

Review comment:
       why update .travis.yml ?

##########
File path: java_util/UUID.go
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package java_util
+
+import (
+	"fmt"
+)
+
+//java.util.UUID
+type UUID struct {
+	MostSigBits  int64 `hessian:"mostSigBits"`
+	LeastSigBits int64 `hessian:"leastSigBits"`
+}
+
+func (UUID) JavaClassName() string {
+	return "java.util.UUID"
+}
+
+func (UUID) Error() string {

Review comment:
       why impl Error()?

##########
File path: java_util_test.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package hessian
+
+import (
+	"testing"
+)
+
+func TestJavaUtil(t *testing.T) {
+	//testDecodeFramework(t, "javautilUUID", &java_util.UUID{LeastSigBits: int64(2020), MostSigBits: int64(8067822391307271002)})

Review comment:
       why comment？

##########
File path: java_util/UUID.go
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package java_util
+
+import (
+	"fmt"
+)
+
+//java.util.UUID
+type UUID struct {
+	MostSigBits  int64 `hessian:"mostSigBits"`
+	LeastSigBits int64 `hessian:"leastSigBits"`
+}
+
+func (UUID) JavaClassName() string {
+	return "java.util.UUID"
+}
+
+func (UUID) Error() string {
+	return "encode java.util.UUID error"
+}
+
+//ToString
+//Returns a string object representing this UUID.
+//The UUID string representation is as described by this BNF:
+//
+// UUID                   = <time_low> "-" <time_mid> "-"
+//                          <time_high_and_version> "-"
+//                          <variant_and_sequence> "-"
+//                          <node>
+// time_low               = 4*<hexOctet>
+// time_mid               = 2*<hexOctet>
+// time_high_and_version  = 2*<hexOctet>
+// variant_and_sequence   = 2*<hexOctet>
+// node                   = 6*<hexOctet>
+// hexOctet               = <hexDigit><hexDigit>
+// hexDigit               =
+//       "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" | "8" | "9"
+//       | "a" | "b" | "c" | "d" | "e" | "f"
+//       | "A" | "B" | "C" | "D" | "E" | "F"
+//
+//Returns:
+//A string representation of this UUID
+func (uuid UUID) ToString() string {
+	uuidStr := fmt.Sprintf("%v-%v-%v-%v-%v",
+		digits((uuid.MostSigBits>>32), 8),

Review comment:
       should remove more brackets




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-770386851


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=h1) Report
   > Merging [#256](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=desc) (06613ee) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0524556634e72a301a31d1023a2181de1f0eadd?el=desc) (c052455) will **decrease** coverage by `0.14%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #256      +/-   ##
   ==========================================
   - Coverage   67.61%   67.46%   -0.15%     
   ==========================================
     Files          25       26       +1     
     Lines        2671     2659      -12     
   ==========================================
   - Hits         1806     1794      -12     
     Misses        644      644              
     Partials      221      221              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [java\_util.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV91dGlsLmdv) | `100.00% <100.00%> (ø)` | |
   | [double.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-ZG91YmxlLmdv) | `85.48% <0.00%> (-1.66%)` | :arrow_down: |
   | [java\_collection.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV9jb2xsZWN0aW9uLmdv) | `49.23% <0.00%> (-1.52%)` | :arrow_down: |
   | [response.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-cmVzcG9uc2UuZ28=) | `52.35% <0.00%> (-0.50%)` | :arrow_down: |
   | [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-bGlzdC5nbw==) | `83.67% <0.00%> (-0.33%)` | :arrow_down: |
   | [date.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-ZGF0ZS5nbw==) | `68.18% <0.00%> (ø)` | |
   | [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `46.07% <0.00%> (ø)` | |
   | [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.40% <0.00%> (ø)` | |
   | [java\_sql\_time.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV9zcWxfdGltZS5nbw==) | `65.67% <0.00%> (ø)` | |
   | [java\_unknown\_exception.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV91bmtub3duX2V4Y2VwdGlvbi5nbw==) | `86.36% <0.00%> (ø)` | |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=footer). Last update [c052455...06613ee](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#discussion_r570189465



##########
File path: java_util/UUID.go
##########
@@ -0,0 +1,71 @@
+/*

Review comment:
       pls  rename this file to uuid.go

##########
File path: java_util/UUID_test.go
##########
@@ -0,0 +1,49 @@
+/*

Review comment:
       pls  rename this file to uuid_test.go




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo merged pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo merged pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-773272088


   @zhangymPerson can u add another unit test , which check whether the uuid string generated by java is equal to that generated by golang ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-770386851


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=h1) Report
   > Merging [#256](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=desc) (06613ee) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0524556634e72a301a31d1023a2181de1f0eadd?el=desc) (c052455) will **decrease** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #256      +/-   ##
   ==========================================
   - Coverage   67.61%   67.56%   -0.05%     
   ==========================================
     Files          25       26       +1     
     Lines        2671     2667       -4     
   ==========================================
   - Hits         1806     1802       -4     
     Misses        644      644              
     Partials      221      221              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [java\_util.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV91dGlsLmdv) | `100.00% <100.00%> (ø)` | |
   | [java\_collection.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV9jb2xsZWN0aW9uLmdv) | `49.23% <0.00%> (-1.52%)` | :arrow_down: |
   | [response.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-cmVzcG9uc2UuZ28=) | `52.35% <0.00%> (-0.50%)` | :arrow_down: |
   | [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-bGlzdC5nbw==) | `83.67% <0.00%> (-0.33%)` | :arrow_down: |
   | [date.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-ZGF0ZS5nbw==) | `68.18% <0.00%> (ø)` | |
   | [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `46.07% <0.00%> (ø)` | |
   | [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.40% <0.00%> (ø)` | |
   | [java\_sql\_time.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV9zcWxfdGltZS5nbw==) | `65.67% <0.00%> (ø)` | |
   | [java\_unknown\_exception.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV91bmtub3duX2V4Y2VwdGlvbi5nbw==) | `86.36% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=footer). Last update [c052455...06613ee](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] AlexStocks commented on a change in pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#discussion_r592192647



##########
File path: java_util_test.go
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package hessian
+
+import (

Review comment:
       pls split this import block.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-773272088


   @zhangymPerson can u add another unit test , which check whether the uuid string generated by java is equal to that generated by golang ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-770386851


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=h1) Report
   > Merging [#256](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=desc) (7a9bd56) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c0524556634e72a301a31d1023a2181de1f0eadd?el=desc) (c052455) will **increase** coverage by `0.04%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #256      +/-   ##
   ==========================================
   + Coverage   67.61%   67.66%   +0.04%     
   ==========================================
     Files          25       26       +1     
     Lines        2671     2675       +4     
   ==========================================
   + Hits         1806     1810       +4     
     Misses        644      644              
     Partials      221      221              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [java\_util.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256/diff?src=pr&el=tree#diff-amF2YV91dGlsLmdv) | `100.00% <100.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=footer). Last update [c052455...7a9bd56](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/256?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #256: Fixes #232 Add go struct refer to java.util.UUID

Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #256:
URL: https://github.com/apache/dubbo-go-hessian2/pull/256#issuecomment-768686041


   ci error: `java_util/UUID.go:68:20: invalid operation: int64(1) << (digits * 4) (shift count type int, must be unsigned integer)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org