You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/06/29 00:41:42 UTC

[GitHub] [cassandra] jonmeredith opened a new pull request, #1708: CASSANDRA-17636 4.0

jonmeredith opened a new pull request, #1708:
URL: https://github.com/apache/cassandra/pull/1708

   See https://issues.apache.org/jira/browse/CASSANDRA-17636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] jonmeredith closed pull request #1708: CASSANDRA-17636 4.0

Posted by GitBox <gi...@apache.org>.
jonmeredith closed pull request #1708: CASSANDRA-17636 4.0
URL: https://github.com/apache/cassandra/pull/1708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] jonmeredith commented on pull request #1708: CASSANDRA-17636 4.0

Posted by GitBox <gi...@apache.org>.
jonmeredith commented on PR #1708:
URL: https://github.com/apache/cassandra/pull/1708#issuecomment-1171614665

   Merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


[GitHub] [cassandra] dcapwell commented on a diff in pull request #1708: CASSANDRA-17636 4.0

Posted by GitBox <gi...@apache.org>.
dcapwell commented on code in PR #1708:
URL: https://github.com/apache/cassandra/pull/1708#discussion_r909106300


##########
test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java:
##########
@@ -412,7 +414,9 @@ public static void changeGossipState(IInvokableInstance target, IInstance peer,
     {
         InetSocketAddress addr = peer.broadcastAddress();
         UUID hostId = peer.config().hostId();
-        int netVersion = peer.getMessagingVersion();
+        int peerVersion = peer.getMessagingVersion();
+        final int netVersion = peerVersion == 0 ? target.getMessagingVersion() :  peerVersion;
+        assert netVersion != 0 : "Unable to determine messaging version for peer {}" + peer.config().num();

Review Comment:
   nit: this is duplicate logic; would be good to create utility function



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org