You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:48:09 UTC
[GitHub] [flink] kl0u opened a new pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
kl0u opened a new pull request #13698:
URL: https://github.com/apache/flink/pull/13698
## What is the purpose of the change
When a pipeline is executed in BATCH mode, its tasks are scheduled in independent regions and not all tasks are present throughout the execution. This implies that checkpoints cannot go through and checkpointing should be disabled.
Given that we want the user code to be able to be executed in BATCH and STREAMING without modifications, with this PR we are simply disabling checkpointing and logging the fact when executing in BATCH mode, but we do not throw an exception.
## Brief change log
Changes are mainly in the `StreamGraphGenerator`.
## Verifying this change
Tests can be found in the `StreamGraphGeneratorExecutionModeDetectionTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915)
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
}, {
"hash" : "7ca2387d71d18bd72c5c5582774fb1424b136294",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7952",
"triggerID" : "7ca2387d71d18bd72c5c5582774fb1424b136294",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924)
* 7ca2387d71d18bd72c5c5582774fb1424b136294 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7952)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #13698:
URL: https://github.com/apache/flink/pull/13698#discussion_r508332076
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -266,6 +266,12 @@ private void configureStreamGraph(final StreamGraph graph) {
graph.setJobName(jobName);
if (shouldExecuteInBatchMode) {
+
+ if (checkpointConfig.isCheckpointingEnabled()) {
+ LOG.info("Disabled Checkpointing. Checkpointing is not supported when executing jobs in BATCH mode.");
+ checkpointConfig.disableCheckpointing();
Review comment:
I agree. The only thing I am afraid is if at any point we are taking again the checkpoint config from the `env` and we disregard what the `StreamGraphGenerator` has set. From a quick look, it does not seem to be the case, so I pushed another commit with the change. Please have a look and let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915)
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13698:
URL: https://github.com/apache/flink/pull/13698#discussion_r508295090
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -266,6 +266,12 @@ private void configureStreamGraph(final StreamGraph graph) {
graph.setJobName(jobName);
if (shouldExecuteInBatchMode) {
+
+ if (checkpointConfig.isCheckpointingEnabled()) {
+ LOG.info("Disabled Checkpointing. Checkpointing is not supported when executing jobs in BATCH mode.");
+ checkpointConfig.disableCheckpointing();
Review comment:
I don't like that we're setting it on the `CheckpointConfig` that the user gave to us. I think it's in general not good that we just pass this through but now is the first time that we modify it here, I think.
Maybe we should do an internal copy of the checkpoint config and then we can modify it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915)
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13698:
URL: https://github.com/apache/flink/pull/13698#discussion_r508343754
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -266,6 +266,12 @@ private void configureStreamGraph(final StreamGraph graph) {
graph.setJobName(jobName);
if (shouldExecuteInBatchMode) {
+
+ if (checkpointConfig.isCheckpointingEnabled()) {
+ LOG.info("Disabled Checkpointing. Checkpointing is not supported when executing jobs in BATCH mode.");
Review comment:
Maybe say "is not supported and not needed"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #13698:
URL: https://github.com/apache/flink/pull/13698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
}, {
"hash" : "7ca2387d71d18bd72c5c5582774fb1424b136294",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ca2387d71d18bd72c5c5582774fb1424b136294",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7924)
* 7ca2387d71d18bd72c5c5582774fb1424b136294 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712673437
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "896df97b435150f2b0e4402315303ec83e1c9215",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915",
"triggerID" : "896df97b435150f2b0e4402315303ec83e1c9215",
"triggerType" : "PUSH"
}, {
"hash" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f523a9c61994de5e74e78085f8bb5e4b5c6056b",
"triggerType" : "PUSH"
}, {
"hash" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccc25111169c6065bd4ff412c00fa72d8d752303",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 896df97b435150f2b0e4402315303ec83e1c9215 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7915)
* 3f523a9c61994de5e74e78085f8bb5e4b5c6056b UNKNOWN
* ccc25111169c6065bd4ff412c00fa72d8d752303 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13698: [FLINK-19732] Disable checkpointing in BATCH mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13698:
URL: https://github.com/apache/flink/pull/13698#issuecomment-712664579
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 896df97b435150f2b0e4402315303ec83e1c9215 (Tue Oct 20 07:50:14 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org