You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by hu...@apache.org on 2018/04/06 23:07:01 UTC

[incubator-heron] branch huijunw/healthmgrmetrics updated: remove unnecessary comment

This is an automated email from the ASF dual-hosted git repository.

huijun pushed a commit to branch huijunw/healthmgrmetrics
in repository https://gitbox.apache.org/repos/asf/incubator-heron.git


The following commit(s) were added to refs/heads/huijunw/healthmgrmetrics by this push:
     new 2e77607  remove unnecessary comment
2e77607 is described below

commit 2e776070afc0015479581dc22e73e4adafc6e044
Author: Huijun Wu <hu...@twitter.com>
AuthorDate: Fri Apr 6 16:06:31 2018 -0700

    remove unnecessary comment
---
 .../src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java       | 1 -
 1 file changed, 1 deletion(-)

diff --git a/heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java b/heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java
index fab5c70..4e41f5b 100644
--- a/heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java
+++ b/heron/healthmgr/src/java/com/twitter/heron/healthmgr/HealthManagerMetrics.java
@@ -227,7 +227,6 @@ public class HealthManagerMetrics implements Runnable, AutoCloseable {
     @Override
     public void onResponse(StatusCode status, Object ctx, Message response) {
       if (status != StatusCode.OK) {
-        // TODO:- is this a good thing?
         throw new RuntimeException("Response from Metrics Manager not ok");
       }
       if (Metrics.MetricPublisherRegisterResponse.class.isInstance(response)) {

-- 
To stop receiving notification emails like this one, please contact
huijun@apache.org.