[GitHub] [netbeans] sdedic commented on a change in pull request #2660: LSP codeAction fixes.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #2660:
URL: https://github.com/apache/netbeans/pull/2660#discussion_r554534757



##########
File path: java/java.hints/src/org/netbeans/modules/java/hints/errors/CreateClassFix.java
##########
@@ -320,9 +320,7 @@ public void run(final WorkingCopy working) throws IOException {
                         default: throw new IllegalStateException();
                     }
                     CompilationUnitTree cut = make.CompilationUnit(targetSourceRoot, packageName.replace('.', '/') + '/' + simpleName + ".java", Collections.<ImportTree>emptyList(), Collections.singletonList(source));
-                    ClassTree nue = createConstructor(working, new TreePath(new TreePath(cut), source));
                     working.rewrite(null, cut);
-                    working.rewrite(source, nue);

Review comment:
       Apologies, I don't quite follow this change - I thought it's desirable to generate a constructor (?). If the constructor is not wanted here, the `implement` method below (also generates one) may need to be modified as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists