[jira] [Commented] (FLINK-9986) Remove unnecessary information from .version.properties file

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559890#comment-16559890 ] 

Chesnay Schepler commented on FLINK-9986:
-----------------------------------------

The problem here is that none of the available properties are guaranteed to match if the binary wasn't derived from the source.

> Remove unnecessary information from .version.properties file
> ------------------------------------------------------------
>
>                 Key: FLINK-9986
>                 URL: https://issues.apache.org/jira/browse/FLINK-9986
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.4.2, 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.6.0
>
>
> To log the revision {{flink-runtime}} creates a {{.version.properties}} file using the {{git-commit-id-plugin}} that is stored within the jar.
> Here's an example:
> {code}
> git.commit.id.abbrev=1a9b648
> git.commit.user.email=chesnay@apache.org
> git.commit.message.full=Commit for release 1.5.2\n
> git.commit.id=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.message.short=Commit for release 1.5.2
> git.commit.user.name=zentol
> git.build.user.name=zentol
> git.build.user.email=chesnay@apache.org
> git.branch=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.time=25.07.2018 @ 17\:10\:13 GMT
> git.build.time=25.07.2018 @ 20\:47\:15 GMT
> git.remote.origin.url=https\://github.com/zentol/flink.git
> {code}
> most of this information isn't used, as flink-runtime only access {{git.commit.id.abbrev}} and {{git.commit.time}}.
> The build, remote and branch information should be removed as they are neither relevant, nor consistent, as releases can be created on any branch, under any git alias, against any remote.
> To exclude properties we have to bump the plugin version to 2.1.9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)