[GitHub] [spark] kiszk commented on pull request #26319: [SPARK-29594][SQL] Provide better error message when creating a Dataset from a Sequence of Case class where a field name started with a number

[GitBox <gi...@apache.org>]

kiszk commented on pull request #26319:
URL: https://github.com/apache/spark/pull/26319#issuecomment-685859011


   This code looks fine with the reported case.
   
   I am curious about the below code. In other word, [`Character.isJavaIdentifier()`](Parthttps://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Character.html#isJavaIdentifierPart(int)) returns `false` regarding the identifier. Should we add this check, too?
   
   ```
   case class Foo(`1+something`: String)
   val test = Seq(Foo("HelloWorld!")).toDS()
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org