You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/11 02:55:12 UTC
[GitHub] [incubator-superset] suddjian edited a comment on issue #9114: fix
Dockerfile for frontend builds
suddjian edited a comment on issue #9114: fix Dockerfile for frontend builds
URL: https://github.com/apache/incubator-superset/pull/9114#issuecomment-584458879
Whew. Had some trials and tribulations as you can see from the commit log but I dare say this is ready to go. Approvals/criticisms welcome.
One change I was forced to make was moving `version_info.json` from `/static/assets` to `/static`. Issues arose around it being built by python code and also around webpack cleaning the contents of `/assets`. version_info isn't really an asset anyway, so I would argue that `/static` is the correct location for it in this directory structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org