You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shijinkui <gi...@git.apache.org> on 2017/01/17 07:14:04 UTC
[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3132
[FLINK-5519] [build] scala-maven-plugin version all change to 3.2.2
1. scala-maven-plugin version all change to 3.2.2 in all module
2. parent pom version change to apache-18 from apache-14
- [X] General
- The pull request references the related JIRA issue ("[FLINK-5519] scala-maven-plugin version all change to 3.2.2")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [X] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [X] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink FLINK-5519_scala-maven-plugin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3132
----
commit d583bf6038c2ffa5a50f7dd4bcc53815ed4cb003
Author: shijinkui <sh...@huawei.com>
Date: 2017-01-17T07:10:52Z
[FLINK-5519] [build] scala-maven-plugin version all change to 3.2.2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3132
Okay, good.
Then I think this is probably good to merge.
@rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3132
Good idea to upgrade the scala plugin. But with this change, it does not define a version at all.
I think it would need to be added to the "plugin management" section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3132
I think its fine (as long as we are not merging it to the 1.2 release branch)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3132
> @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?
@StephanEwen There's no effect to the create_release_files.sh in my opinion.
from v14 to v18, there are some plugins' version upgrade.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3132#discussion_r96582962
--- Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml ---
@@ -313,7 +313,6 @@ under the License.
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <version>3.1.4</version>
--- End diff --
I think you an not remove the version here. Where does the generated project get the plugin version from?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3132
Looks good, thanks. merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3132: [FLINK-5519] [build] scala-maven-plugin version all chang...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3132
@StephanEwen There already is an entry for `scala-maven-plugin` in the plugin management section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on a diff in the pull request:
https://github.com/apache/flink/pull/3132#discussion_r96585227
--- Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml ---
@@ -313,7 +313,6 @@ under the License.
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <version>3.1.4</version>
--- End diff --
have fix it. Thanks for review:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3132: [FLINK-5519] [build] scala-maven-plugin version al...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---