You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mikaelstaldal <gi...@git.apache.org> on 2016/07/22 16:39:57 UTC

[GitHub] spark pull request #14320: [SPARK-16416] [Core] force eager creation of logg...

GitHub user mikaelstaldal opened a pull request:

    https://github.com/apache/spark/pull/14320

    [SPARK-16416] [Core] force eager creation of loggers to avoid shutdown hook conflicts

    ## What changes were proposed in this pull request?
    
    Force eager creation of loggers to avoid shutdown hook conflicts.
    
    
    ## How was this patch tested?
    
    Manually tested with a project using Log4j 2, verified that the shutdown hook conflict issue was solved.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mikaelstaldal/spark shutdown-hook-logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14320
    
----
commit 334adafa85dd1dca5485ccbbe7a17645c12fc52f
Author: Mikael St�ldal <mi...@magine.com>
Date:   2016-07-22T15:15:42Z

    Force eager creation of loggers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    Jenkins test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62765/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by mikaelstaldal <gi...@git.apache.org>.

Github user mikaelstaldal commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    I realized that it is necessary everywhere where you register a shutdown hook, if you log from within the shutdown hook.
    
    Another way to solve it would be to refrain to log from within shutdown hooks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    **[Test build #62765 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62765/consoleFull)** for PR 14320 at commit [`334adaf`](https://github.com/apache/spark/commit/334adafa85dd1dca5485ccbbe7a17645c12fc52f).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    OK, seems reasonable to me as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    **[Test build #62765 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62765/consoleFull)** for PR 14320 at commit [`334adaf`](https://github.com/apache/spark/commit/334adafa85dd1dca5485ccbbe7a17645c12fc52f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    This doesn't seem to be the change discussed in the JIRA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14320: [SPARK-16416] [Core] force eager creation of loggers to ...

Posted by mikaelstaldal <gi...@git.apache.org>.

Github user mikaelstaldal commented on the issue:

    https://github.com/apache/spark/pull/14320
  
    It is, I just had to apply the same in several places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org