You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/04 15:59:58 UTC
[jira] [Commented] (THRIFT-4019) Dart Makefiles should also clean
pubspec.lock
[ https://issues.apache.org/jira/browse/THRIFT-4019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798583#comment-15798583 ]
ASF GitHub Bot commented on THRIFT-4019:
----------------------------------------
GitHub user markerickson-wf opened a pull request:
https://github.com/apache/thrift/pull/1150
THRIFT-4019 Dart Makefiles should also clean pubspec.lock
@ericklaus-wf
FYI @allengeorge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markerickson-wf/thrift thrift-4019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1150.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1150
----
commit 671fd58925111a87cc18bbc86d76af46c5dc2658
Author: Mark Erickson <ma...@workiva.com>
Date: 2017-01-04T15:56:24Z
THRIFT-4019 Dart Makefiles should also clean pubspec.lock
----
> Dart Makefiles should also clean pubspec.lock
> ---------------------------------------------
>
> Key: THRIFT-4019
> URL: https://issues.apache.org/jira/browse/THRIFT-4019
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Reporter: Mark Erickson
> Assignee: Mark Erickson
> Fix For: 0.10.0
>
>
> Dart pub get produces a pubspec.lock file, which is git-ignored. These should be removed as part of `make clean`.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)