You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/28 17:03:00 UTC
[GitHub] tysonnorris commented on a change in pull request #4312: Record
clusterId performing change in CosmosDB
tysonnorris commented on a change in pull request #4312: Record clusterId performing change in CosmosDB
URL: https://github.com/apache/incubator-openwhisk/pull/4312#discussion_r261292244
##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBArtifactStore.scala
##########
@@ -445,7 +462,8 @@ class CosmosDBArtifactStore[DocumentAbstraction <: DocumentSerializer](protected
Seq(
(cid, Some(JsString(escapeId(json.fields(_id).convertTo[String])))),
(etag, json.fields.get(_rev)),
- (computed, computedOpt))
+ (computed, computedOpt),
+ (clusterId, clusterIdValue))
Review comment:
Minor: It may be worth noting (comment in the cluster id config?) that clusterId may change in the case where doc is created from one cluster, and edited from another, when both clusters use the same collection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services