[GitHub] [incubator-pegasus] neverchanje edited a comment on pull request #602: build: remove restrict to build from non-git-repo

[GitBox <gi...@apache.org>]

neverchanje edited a comment on pull request #602:
URL: https://github.com/apache/incubator-pegasus/pull/602#issuecomment-693766344


   `PEGASUS_GIT_COMMIT` is a complement of `PEGASUS_VERSION` (src/include/pegasus/version.h), in my opinion. So I just keep consistent with what it is in non-git repo. But truth is, I agree that `PEGASUS_GIT_COMMIT` has no much use.
   
   `PEGASUS_GIT_COMMIT` is not "generated" from the downloaded source. It exists in the source package as the `GIT_COMMIT` file which is provided by who produced the package, via `bump_version.sh`.
   
   So when you cherry-pick to the release branch, it won't be updated. It updates when you call `bump_version.sh`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org