You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/05/30 07:22:26 UTC

[james-project] 15/19: MAILBOX-351 MemoryTaskManagerWorker can rely on Task.Status::isFinished

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 520cc5c6c1d97eb4897c0aa2a77d234503b0af31
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Tue May 28 15:21:13 2019 +0700

    MAILBOX-351 MemoryTaskManagerWorker can rely on Task.Status::isFinished
---
 .../src/main/java/org/apache/james/task/MemoryTaskManagerWorker.java  | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/server/task/src/main/java/org/apache/james/task/MemoryTaskManagerWorker.java b/server/task/src/main/java/org/apache/james/task/MemoryTaskManagerWorker.java
index e69e641..5d6226d 100644
--- a/server/task/src/main/java/org/apache/james/task/MemoryTaskManagerWorker.java
+++ b/server/task/src/main/java/org/apache/james/task/MemoryTaskManagerWorker.java
@@ -120,9 +120,7 @@ public class MemoryTaskManagerWorker implements TaskManagerWorker {
     }
 
     private boolean canBeCancelledEffectively(TaskExecutionDetails details) {
-        return details.getStatus().equals(TaskManager.Status.WAITING)
-            || details.getStatus().equals(TaskManager.Status.IN_PROGRESS)
-            || details.getStatus().equals(TaskManager.Status.CANCEL_REQUESTED);
+        return !details.getStatus().isFinished();
     }
 
     private void success(Consumer<TaskExecutionDetailsUpdater> updateDetails) {


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org