You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Andrew Wang (JIRA)" <ji...@apache.org> on 2012/07/24 19:07:36 UTC
[jira] [Created] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Andrew Wang created HDFS-3719:
---------------------------------
Summary: Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
Key: HDFS-3719
URL: https://issues.apache.org/jira/browse/HDFS-3719
Project: Hadoop HDFS
Issue Type: Bug
Components: test
Reporter: Andrew Wang
Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
{code}
// fails due to issue w/append, disable
@Ignore
@Test
public void _testUnfinishedBlockCRCErrorTransferToAppend()
throws IOException {
runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
}
// fails due to issue w/append, disable
@Ignore
@Test
public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
throws IOException {
runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3719:
---------------------------------
Summary: Re-enable append-related tests in TestFileConcurrentReader (was: Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend)
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3719:
---------------------------------
Fix Version/s: (was: 2.2.0-alpha)
I've just reverted this.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429152#comment-13429152 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2554 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2554/])
HDFS-3719. Re-enable append-related tests in TestFileConcurrentReader. Contributed by Andrew Wang. (Revision 1369848)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1369848
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433457#comment-13433457 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2593 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2593/])
Revert HDFS-3719. See discussion there and HDFS-3770 for more info. (Revision 1372544)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372544
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429151#comment-13429151 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2619 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2619/])
HDFS-3719. Re-enable append-related tests in TestFileConcurrentReader. Contributed by Andrew Wang. (Revision 1369848)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1369848
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433415#comment-13433415 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2637 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2637/])
Revert HDFS-3719. See discussion there and HDFS-3770 for more info. (Revision 1372544)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372544
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Andrew Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wang updated HDFS-3719:
------------------------------
Assignee: Andrew Wang
Status: Patch Available (was: Open)
Looking at this in more detail, these two tests have been disabled since the initial commit in HDFS-1057. Since I suppose append has been fixed in the two years since, I simply re-enabled them and tried running each of them a few times and they passed.
Simple patch attached, lets see what Jenkins says.
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433419#comment-13433419 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2572 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2572/])
Revert HDFS-3719. See discussion there and HDFS-3770 for more info. (Revision 1372544)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372544
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430829#comment-13430829 ]
Aaron T. Myers commented on HDFS-3719:
--------------------------------------
Eli filed HDFS-3770 to address the test failure, and has some good analysis for what the root cause may be.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Andrew Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wang updated HDFS-3719:
------------------------------
Attachment: hdfs-3719-1.patch
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428557#comment-13428557 ]
Hadoop QA commented on HDFS-3719:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12539109/hdfs-3719-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2954//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2954//console
This message is automatically generated.
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers reopened HDFS-3719:
----------------------------------
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3719:
---------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've just committed this to trunk and branch-2.
Thanks a lot for the contribution, Andrew.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429148#comment-13429148 ]
Aaron T. Myers commented on HDFS-3719:
--------------------------------------
+1, the patch looks good to me. I'm going to commit this momentarily.
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433400#comment-13433400 ]
Aaron T. Myers commented on HDFS-3719:
--------------------------------------
OK, since it appears there's more to these failing tests than a simple fix, I'm going to go ahead and revert this change to re-enable the tests.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Andrew Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Wang updated HDFS-3719:
------------------------------
Affects Version/s: 2.0.0-alpha
Set affects version to 2.0.0-alpha, thanks Suresh.
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435076#comment-13435076 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1167 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1167/])
Revert HDFS-3719. See discussion there and HDFS-3770 for more info. (Revision 1372544)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372544
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435047#comment-13435047 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1135 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1135/])
Revert HDFS-3719. See discussion there and HDFS-3770 for more info. (Revision 1372544)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372544
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430828#comment-13430828 ]
Todd Lipcon commented on HDFS-3719:
-----------------------------------
It seems like this tests have been failing a lot since getting re-enabled.
Andrew, do you have time to take a look? Otherwise I think we should revert this.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429174#comment-13429174 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2573 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2573/])
HDFS-3719. Re-enable append-related tests in TestFileConcurrentReader. Contributed by Andrew Wang. (Revision 1369848)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1369848
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421859#comment-13421859 ]
Suresh Srinivas commented on HDFS-3719:
---------------------------------------
Can you set Affect Version/s field please.
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Reporter: Andrew Wang
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Andrew Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432225#comment-13432225 ]
Andrew Wang commented on HDFS-3719:
-----------------------------------
I'm fine with reverting this until a fix emerges for HDFS-3770. I'll take a look, but based on the amount of discussion surrounding the fix for HDFS-1057, things might not be simple.
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3719) Re-enable append-related tests in
TestFileConcurrentReader
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430330#comment-13430330 ]
Hudson commented on HDFS-3719:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1128 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1128/])
HDFS-3719. Re-enable append-related tests in TestFileConcurrentReader. Contributed by Andrew Wang. (Revision 1369848)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1369848
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileConcurrentReader.java
> Re-enable append-related tests in TestFileConcurrentReader
> ----------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Fix For: 2.2.0-alpha
>
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3719) Fix
TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and
#testUnfinishedBlockCRCErrorNormalTransferAppend
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-3719:
---------------------------------
Target Version/s: 2.2.0-alpha
> Fix TestFileConcurrentReader#testUnfinishedBlockCrcErrorTransferToAppend and #testUnfinishedBlockCRCErrorNormalTransferAppend
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-3719
> URL: https://issues.apache.org/jira/browse/HDFS-3719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 2.0.0-alpha
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-3719-1.patch
>
>
> Both of these tests are disabled. We should figure out what append functionality we need to make the tests work again, and reenable them.
> {code}
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorTransferToAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(true, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> // fails due to issue w/append, disable
> @Ignore
> @Test
> public void _testUnfinishedBlockCRCErrorNormalTransferAppend()
> throws IOException {
> runTestUnfinishedBlockCRCError(false, SyncType.APPEND, DEFAULT_WRITE_SIZE);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira