You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/26 21:14:20 UTC

[kudu-CR] tpch: switch CPU to performance mode before running benchmark

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1910

to review the following change.

Change subject: tpch: switch CPU to performance mode before running benchmark
......................................................................

tpch: switch CPU to performance mode before running benchmark

For benchmarks, it's important to disable frequency scaling to get
consistent results. We were already doing this for the main benchmarks
script, but not for the tpch test. One of our benchmark slaves was
set to 'performance' mode whereas another is set to 'ondemand'
which resulted in about a 2x difference in performance on this benchmark.

This refactors out some code for setting the frequency governor and
uses it in the TPCH script.

Change-Id: If917950cef028470d0e603475a236847b1cccd46
---
M src/kudu/scripts/benchmarks.sh
A src/kudu/scripts/ensure_cpu_scaling.sh
M src/kudu/scripts/tpch.sh
3 files changed, 35 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/1910/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If917950cef028470d0e603475a236847b1cccd46
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans