You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "zzzzzzzs (via GitHub)" <gi...@apache.org> on 2023/04/22 14:53:30 UTC
[GitHub] [flink] zzzzzzzs opened a new pull request, #22452: [FLINK-31799][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.
zzzzzzzs opened a new pull request, #22452:
URL: https://github.com/apache/flink/pull/22452
## Brief change log
fix the typo in docs/content/docs/libs/cep.md
fix the typo in docs/content.zh/docs/libs/cep.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22452: [FLINK-31881][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22452:
URL: https://github.com/apache/flink/pull/22452#discussion_r1175218838
##########
docs/content.zh/docs/libs/cep.md:
##########
@@ -477,6 +477,11 @@ pattern.oneOrMore()
pattern.timesOrMore(2);
```
{{< /tab >}}
+{{< tab "Scala" >}}
+```scala
+pattern.timesOrMore(2)
+```
+{{< /tab >}}
Review Comment:
Given that Scala is deprecated for Flink, I'm really wondering if we should add more code examples for Scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22452: [FLINK-31799][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22452:
URL: https://github.com/apache/flink/pull/22452#issuecomment-1518680512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6f4c4cf66dd625d756a185cfd98dc8e66ff65e04",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f4c4cf66dd625d756a185cfd98dc8e66ff65e04",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f4c4cf66dd625d756a185cfd98dc8e66ff65e04 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser merged pull request #22452: [FLINK-31881][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #22452:
URL: https://github.com/apache/flink/pull/22452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zzzzzzzs commented on a diff in pull request #22452: [FLINK-31881][docs] Fix the confusion in the Chinese documentation page of Flink official CEP, and add the Scala code of timesOrMore.
Posted by "zzzzzzzs (via GitHub)" <gi...@apache.org>.
zzzzzzzs commented on code in PR #22452:
URL: https://github.com/apache/flink/pull/22452#discussion_r1175917651
##########
docs/content.zh/docs/libs/cep.md:
##########
@@ -477,6 +477,11 @@ pattern.oneOrMore()
pattern.timesOrMore(2);
```
{{< /tab >}}
+{{< tab "Scala" >}}
+```scala
+pattern.timesOrMore(2)
+```
+{{< /tab >}}
Review Comment:
Sorry, as Flink has deprecated Scala, I have removed this section from the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org