You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by "Julia (JIRA)" <ji...@apache.org> on 2016/12/02 22:23:58 UTC

[jira] [Created] (REEF-1683) Use default MaxRetryNumberInRecovery properly

Julia created REEF-1683:
---------------------------

             Summary: Use default MaxRetryNumberInRecovery properly
                 Key: REEF-1683
                 URL: https://issues.apache.org/jira/browse/REEF-1683
             Project: REEF
          Issue Type: Bug
            Reporter: Julia
            Priority: Minor


Currently in IMRUJobDefinitionBuilder, the default _maxRetryNumberInRecovery is set to 0. In REEFIMRUClient and some test code, we bind the value in  IMRUJobDefinition to the named parameter MaxRetryNumberInRecovery. If the user doesn't set this value in IMRUJobDefinitionBuilder when creating IMRUJobDefinition, the default value 0 is bound to the NamedParameter, which override the named parameter MaxRetryNumberInRecovery's own default value. 
In IMRUDriver, to avoid this override, we set another default value and replace the value passed in if it 0. That caused some confusion. 
A correct way should be, if the user doesn't  set, REEFIMRUClient should not bind 0 to the named parameter, that would allow the named parameter's own default value to be used.  And when we look for the default value, the one set in the named parameter should be the unique place. 





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)