You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/06/04 21:36:05 UTC
[GitHub] tinkerpop pull request #871: TINKERPOP-1975 Introduced with() step and Confi...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/871
TINKERPOP-1975 Introduced with() step and Configuring interface
https://issues.apache.org/jira/browse/TINKERPOP-1975
This PR is about `with()` step which introduces a way to provide a way to supply configurations to steps. Especially useful for algorithm type steps like `pageRank()` which had previously relied on `by()` which was insufficient for this purposes and a bit forced to try to prevent additional expansion of the core API.
As a result of `with()` we now have the `Configuring` interface to apply to steps that can accept `with()` options. Moved `Parameterizing` to the package containing the other step interfaces. Changed interface hierarchy with `Parameterizing` and `Mutating` now that `Configuring` is present. Both of those changes make this body of work a breaking change to existing APIs though it should really only affect graph providers and even then the fix is quite simple as described in the upgrade documentation.
Will edit this description when ready for review - once tests complete.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/871.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #871
----
commit 0dca3ff9d2f78e145a807e28fd58c1a0cf452cb6
Author: Stephen Mallette <sp...@...>
Date: 2018-05-31T16:55:13Z
TINKERPOP-1975 Introduced with() step and Configuring interface
Moved Parameterizing to the package containing the other step interfaces. Changed interface hierarchy with Parameterizing and Mutating now that Configuring is present. Both of those changes make this body of work a breaking change to existing APIs though it should really only affect graph providers and even then the fix is quite simple as described in the upgrade documentation.
----
---
[GitHub] tinkerpop issue #871: TINKERPOP-1975 Introduced with() step and Configuring ...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/871
VOTE: +1
---
[GitHub] tinkerpop issue #871: TINKERPOP-1975 Introduced with() step and Configuring ...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/871
VOTE +1
---
[GitHub] tinkerpop pull request #871: TINKERPOP-1975 Introduced with() step and Confi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/871
---
[GitHub] tinkerpop pull request #871: TINKERPOP-1975 Introduced with() step and Confi...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/871#discussion_r192922149
--- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/CoreImports.java ---
@@ -260,6 +261,7 @@
CLASS_IMPORTS.add(PeerPressureVertexProgram.class);
CLASS_IMPORTS.add(PageRankMapReduce.class);
CLASS_IMPORTS.add(PageRankVertexProgram.class);
+ CLASS_IMPORTS.add(PageRankVertexProgramStep.PageRank.class);
--- End diff --
I think `PeerPressureVertexProgramStep.PeerPressure` should be a core import too.
---