You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2014/07/15 15:25:17 UTC
Re: stop copying footers to r->headers_in?
Candidate patch uses %I and %O but they are used by mod_logio. It is
hard to find two good unused characters.
What do people think about allowing two-character log formats? I
think patch below only breaks someone who had a %XX where XX is a
registered two digit tag and they expect the 1 char + literal (seems
safe enough to me even for 2.2)
http://people.apache.org/~covener/patches/httpd-trunk-logger-2chars.diff
Patch includes the trailers stuff in mod_log_config.
Test seems to work, normal access log unchanged and %{foo}Ti hits with
printf "GET / HTTP/1.1\r\nHost: localhost\r\nTransfer-Encoding:
chunked\r\n\r\n0\r\nFoo: bar\r\n\r\n" |nc 0 80
On Wed, Jun 25, 2014 at 1:23 PM, Edward Lu <ch...@gmail.com> wrote:
> Patch for trunk as well
>
>
> On Wed, Jun 25, 2014 at 1:20 PM, Edward Lu <ch...@gmail.com> wrote:
>>
>> Wanted to follow up on this thread again; here's my latest patch on 2.2.x
>> that takes some ideas from Joe's patch. I also merge the trailers into the
>> headers after reading them now, instead of directly appending them into the
>> headers.
>>
>> I will leave the PROXYREQ_RESPONSE case to someone else, as I still don't
>> fully understand it.
>>
>>
>> On Thu, May 15, 2014 at 3:20 PM, Yann Ylavic <yl...@gmail.com> wrote:
>>>
>>> I did not realize your mail is 8 days old, I just received it -- gmail
>>> is having fun these days :(
>>> Sorry for this misunderstanding and the reply that goes along...
>>>
>>> Regards,
>>> Yann.
>>
>>
>
--
Eric Covener
covener@gmail.com
Re: stop copying footers to r->headers_in?
Posted by Eric Covener <co...@gmail.com>.
On Tue, Jul 15, 2014 at 11:07 AM, Plüm, Rüdiger, Vodafone Group
<ru...@vodafone.com> wrote:
> This should work. But don't you need to register then ^Ti instead of Ti?
yeah, it needs to be registered and used in httpd.conf w/ the ^
--
Eric Covener
covener@gmail.com
RE: stop copying footers to r->headers_in?
Posted by Plüm,
Rüdiger,
Vodafone Group <ru...@vodafone.com>.
> -----Original Message-----
> From: Eric Covener [mailto:covener@gmail.com]
> Sent: Dienstag, 15. Juli 2014 17:02
> To: Apache HTTP Server Development List
> Subject: Re: stop copying footers to r->headers_in?
>
> On Tue, Jul 15, 2014 at 10:56 AM, Plüm, Rüdiger, Vodafone Group
> <ru...@vodafone.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Eric Covener [mailto:covener@gmail.com]
> >> Sent: Dienstag, 15. Juli 2014 16:52
> >> To: Apache HTTP Server Development List
> >> Subject: Re: stop copying footers to r->headers_in?
> >>
> >> On Tue, Jul 15, 2014 at 10:38 AM, Plüm, Rüdiger, Vodafone Group
> >> <ru...@vodafone.com> wrote:
> >> > Is there a way for people with such a setup to fix this with a
> different
> >> config?
> >> > From the top of my head I would say no and that would be a blocker.
> >>
> >> Do you think the required '^' prefix in the followup is enough? In
> >
> > I think I missed the follow up. Where can I find it?
>
> http://svn.apache.org/viewvc?view=revision&revision=r1610707
This should work. But don't you need to register then ^Ti instead of Ti?
Regards
Rüdiger
Re: stop copying footers to r->headers_in?
Posted by Eric Covener <co...@gmail.com>.
On Tue, Jul 15, 2014 at 10:56 AM, Plüm, Rüdiger, Vodafone Group
<ru...@vodafone.com> wrote:
>
>
>> -----Original Message-----
>> From: Eric Covener [mailto:covener@gmail.com]
>> Sent: Dienstag, 15. Juli 2014 16:52
>> To: Apache HTTP Server Development List
>> Subject: Re: stop copying footers to r->headers_in?
>>
>> On Tue, Jul 15, 2014 at 10:38 AM, Plüm, Rüdiger, Vodafone Group
>> <ru...@vodafone.com> wrote:
>> > Is there a way for people with such a setup to fix this with a different
>> config?
>> > From the top of my head I would say no and that would be a blocker.
>>
>> Do you think the required '^' prefix in the followup is enough? In
>
> I think I missed the follow up. Where can I find it?
http://svn.apache.org/viewvc?view=revision&revision=r1610707
RE: stop copying footers to r->headers_in?
Posted by "Houser, Rick" <ri...@us.pgds.com>.
That would be at least half my fault for responding off-list... Here it is:
----------------------------
Thanks -- I went with ^
Shouldn't have much worry about responding to dev@
On Tue, Jul 15, 2014 at 9:42 AM, Houser, Rick <ri...@us.pgds.com> wrote:
> New to this list, so responding directly until I have a better feel....
>
> Wouldn't a three character tag be safer with the first being a dedicated (unused) prefix to unlock the additional bytes, like Unicode? Something like this:
>
> _<char1><char2> (note, I didn't check if _ was used -- just using it as an example)
>
>
> Rick Houser
Rick Houser
Web Administration
(517)367-3516
> -----Original Message-----
> From: Plüm, Rüdiger, Vodafone Group
> [mailto:ruediger.pluem@vodafone.com]
> Sent: Tuesday, July 15, 2014 10:56 AM
> To: dev@httpd.apache.org
> Subject: RE: stop copying footers to r->headers_in?
>
>
>
> > -----Original Message-----
> > From: Eric Covener [mailto:covener@gmail.com]
> > Sent: Dienstag, 15. Juli 2014 16:52
> > To: Apache HTTP Server Development List
> > Subject: Re: stop copying footers to r->headers_in?
> >
> > On Tue, Jul 15, 2014 at 10:38 AM, Plüm, Rüdiger, Vodafone Group
> > <ru...@vodafone.com> wrote:
> > > Is there a way for people with such a setup to fix this with a different
> > config?
> > > From the top of my head I would say no and that would be a blocker.
> >
> > Do you think the required '^' prefix in the followup is enough? In
>
> I think I missed the follow up. Where can I find it?
>
> Regards
>
> Rüdiger
RE: stop copying footers to r->headers_in?
Posted by Plüm,
Rüdiger,
Vodafone Group <ru...@vodafone.com>.
> -----Original Message-----
> From: Eric Covener [mailto:covener@gmail.com]
> Sent: Dienstag, 15. Juli 2014 16:52
> To: Apache HTTP Server Development List
> Subject: Re: stop copying footers to r->headers_in?
>
> On Tue, Jul 15, 2014 at 10:38 AM, Plüm, Rüdiger, Vodafone Group
> <ru...@vodafone.com> wrote:
> > Is there a way for people with such a setup to fix this with a different
> config?
> > From the top of my head I would say no and that would be a blocker.
>
> Do you think the required '^' prefix in the followup is enough? In
I think I missed the follow up. Where can I find it?
Regards
Rüdiger
Re: stop copying footers to r->headers_in?
Posted by Eric Covener <co...@gmail.com>.
On Tue, Jul 15, 2014 at 10:38 AM, Plüm, Rüdiger, Vodafone Group
<ru...@vodafone.com> wrote:
> Is there a way for people with such a setup to fix this with a different config?
> From the top of my head I would say no and that would be a blocker.
Do you think the required '^' prefix in the followup is enough? In
this case, to be broken, you would have a custom module that accepted
%^ AND you would have had two constant characters in your format that
match a newly added format.
--
Eric Covener
covener@gmail.com
Re: stop copying footers to r->headers_in?
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Jul 15, 2014, at 10:38 AM, Plüm, Rüdiger, Vodafone Group <ru...@vodafone.com> wrote:
>
>
>> -----Original Message-----
>> From: Eric Covener [mailto:covener@gmail.com]
>> Sent: Dienstag, 15. Juli 2014 15:25
>> To: Apache HTTP Server Development List
>> Subject: Re: stop copying footers to r->headers_in?
>>
>> Candidate patch uses %I and %O but they are used by mod_logio. It is
>> hard to find two good unused characters.
>>
>> What do people think about allowing two-character log formats? I
>> think patch below only breaks someone who had a %XX where XX is a
>> registered two digit tag and they expect the 1 char + literal (seems
>> safe enough to me even for 2.2)
>
> Is there a way for people with such a setup to fix this with a different config?
> From the top of my head I would say no and that would be a blocker.
>
Agreed
Re: stop copying footers to r->headers_in?
Posted by Tim Bannister <is...@jellybaby.net>.
On 15 Jul 2014, at 15:38, Rüdiger Plüm <ru...@vodafone.com> wrote:
> -----Original Message-----
>> From: Eric Covener [mailto:covener@gmail.com]
>> Sent: Dienstag, 15. Juli 2014 15:25
>> To: Apache HTTP Server Development List
>> Subject: Re: stop copying footers to r->headers_in?
>> What do people think about allowing two-character log formats? I
>> think patch below only breaks someone who had a %XX where XX is a
>> registered two digit tag and they expect the 1 char + literal (seems
>> safe enough to me even for 2.2)
>
> Is there a way for people with such a setup to fix this with a different config?
> From the top of my head I would say no and that would be a blocker.
%{thing}[label] perhaps? Maybe it's too confusing / contrived, maybe it's not needed (yet).
Like this, for an imaginary new format string label %[foo]
LogFormat "%{%Y-%m-%d}tT%{%H:%M:%S}t%{usec_frac}t %{usec_frac}[foo]"
and for another label %[bar]:
LogFormat "%{sec}t%{msec_frac}t %>s %<[bar] %<L" "%{REQUEST_STATUS} -strcmatch '5*'"
--
Tim Bannister – isoma@jellybaby.net
RE: stop copying footers to r->headers_in?
Posted by Plüm,
Rüdiger,
Vodafone Group <ru...@vodafone.com>.
> -----Original Message-----
> From: Eric Covener [mailto:covener@gmail.com]
> Sent: Dienstag, 15. Juli 2014 15:25
> To: Apache HTTP Server Development List
> Subject: Re: stop copying footers to r->headers_in?
>
> Candidate patch uses %I and %O but they are used by mod_logio. It is
> hard to find two good unused characters.
>
> What do people think about allowing two-character log formats? I
> think patch below only breaks someone who had a %XX where XX is a
> registered two digit tag and they expect the 1 char + literal (seems
> safe enough to me even for 2.2)
Is there a way for people with such a setup to fix this with a different config?
From the top of my head I would say no and that would be a blocker.
Regards
Rüdiger