[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473300#comment-15473300 ] 

ASF GitHub Bot commented on FLINK-4068:
---------------------------------------

Github user wuchong commented on the issue:

    https://github.com/apache/flink/pull/2102
  
    As I mentioned above, the `cannot translate call AS($t0, $t1)` error because of a Calcite bug. The [CALCITE-1297](https://issues.apache.org/jira/browse/CALCITE-1297) fixed it , but not yet released.  I will wait for Calcite 1.9 released and start working on it. 


> Move constant computations out of code-generated `flatMap` functions.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-4068
>                 URL: https://issues.apache.org/jira/browse/FLINK-4068
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.1.0
>            Reporter: Fabian Hueske
>            Assignee: Jark Wu
>
> The generated functions for expressions of the Table API or SQL include constant computations.
> For instance the code generated for a predicate like:
> {code}
> myInt < (10 + 20)
> {code}
> looks roughly like:
> {code}
> public void flatMap(Row in, Collector<Row> out) {
>   Integer in1 = in.productElement(1);
>   int temp = 10 + 20;  
>   if (in1 < temp) {
>     out.collect(in)
>   }
> }
> {code}
> In this example the computation of {{temp}} is constant and could be moved out of the {{flatMap()}} method.
> The same might apply for generated function other than {{FlatMap}} as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)