You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/09 22:51:50 UTC

[kudu-CR](branch-1.17.x) Squash cherry-picked commits #9 This is a combination of 20 commits.

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21772


Change subject: Squash cherry-picked commits #9 This is a combination of 20 commits.
......................................................................

Squash cherry-picked commits #9
This is a combination of 20 commits.

This is the 1st commit message:

[build] Fix RocksDB Snappy dependency.

RocksDB uses Snappy. When statically linking Kudu, librocksdb.a contains
multiple undefined symbols that are defined in libsnappy.a. In the case
of static linking, the order of libraries passed to the linker matters,
and libsnappy.a must come after librocksdb.a. This sometimes causes the
release build to fail on RHEL 9.3.

Reviewed-on: http://gerrit.cloudera.org:8080/21370
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit fdb42489d76098eeca371ac57ae02ea176438c64)

This is the commit message #2:

[tablet] fix WriteOp::ToString() for non-started ops

After [1] and prior to this patch, at least linked_list-test and
update_scan_delta_compact-test would fail from time to time with
DCHECK triggered like in the snippet below:

  F20240430 19:48:41.064476 2463727 monotime.cc:342] Check failed: t_beg.Initialized()
  *** Check failure stack trace: ***
      @     0x7f3c1472548d  google::LogMessage::Fail() at ??:0
      @     0x7f3c147290d7  google::LogMessage::SendToLog() at ??:0
      @     0x7f3c14724e8c  google::LogMessage::Flush() at ??:0
      @     0x7f3c147265c9  google::LogMessageFatal::~LogMessageFatal() at ??:0
      @     0x7f3c1564dff0  kudu::operator-() at ??:0
      @     0x7f3c1b46a0cd  kudu::tablet::WriteOp::ToString() at ??:0
      @     0x7f3c1b454416  kudu::tablet::OpDriver::ToStringUnlocked() at ??:0
      @     0x7f3c1b45436f  kudu::tablet::OpDriver::ToString() at ??:0
      @     0x7f3c1b42d154  kudu::tablet::TabletReplica::GetInFlightOps() at ??:0
      @     0x7f3c1c121c1d  kudu::tserver::TabletServerPathHandlers::HandleTransactionsPage() at ??:0

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/ad3936521af034ffcac637f97cd8c932f6289b4f

Reviewed-on: http://gerrit.cloudera.org:8080/21381
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit c39e72a98e124e5a12080bac42105b996594d806)

This is the commit message #3:

[tserver] limit number of trace metrics for TabletCopyClient

The trace metrics registry assumes that the number of entries is quite
small, with the current threshold of 100.  In its turn, a thread pool
unconditionally registers and updates its trace metrics while executing
submitted tasks.  Since a tablet server might host thousands of tablet
replicas, it's not a good idea to include the UUID of the tablet into
the name of the download thread pool spawned by every TabletCopyClient
instance.

This is a follow-up to 0d95304fa46ee5d96bcaa934c7660369f2860e06.

Reviewed-on: http://gerrit.cloudera.org:8080/21393
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit 732f0c1e51bca04091431859918a3b84866373a0)

This is the commit message #4:

[g++11] Fix DecrementIntCell for g++10 and g++11

There seems to be a compiler bug, that optimizes out the safety check
for INT_MIN in the DecrementIntCell function. It appears on RHEL 9.2
with g++ 11.4.1. Only in Release build. For more infoi, see:

https://stackoverflow.com/questions/78424303/g-optimizes-away-check-for-int-min-in-release-build

The issue seems to be fixed in g++12 and not yet present in g++9.

Solution:
Slightly change the function to ensure it is compiled correctly.
This modification should not alter the correct optimized code.

Basically, any change where the compiler cannot perform the two
optimization steps (in this order) should address the issue:

+ if (x == INT_MIN) x = INT_MAX; else x -= 1; ====> x -= 1
(this is equivalent on the x86 platform).
+ if (x - 1 < x) ====> if (true)
(this equivalence holds only at the mathematical level).

Reviewed-on: http://gerrit.cloudera.org:8080/21396
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 1f0c0b0172fb211e74848c87fce983e45280e66d)

This is the commit message #5:

[CMakeLists] Make kudu_test_main static

This change makes sure that kudu_util.so is loaded at the beginning of
the library search order. This is needed because in unwind_safeness.cc
there is a dlsym execution in the constructor function, that creates a
wrapper for dlopen and dlclose to prevent a potential deadlock during
unwind stack resolve. It looks for the next declaration of the functions
called "dlopen" and "dlclose" in shared object files. If kudu_util is
loaded too late, then it won't find these functions and throws an error.
This happens in ubuntu 22.04 test runs. To solve this issue, the
kudu_test_main was changed to a static library and kudu_util was moved
to the front of the library list.

This is a best effort fix, and it should only have impact on test
execution.

Reviewed-on: http://gerrit.cloudera.org:8080/21282
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 259fcc2b501077402e3d0e0d474a7ca475b70b5f)

This is the commit message #6:

[metrics] Add metrics for create and delete op time

Add server-level statistics to track the time consumption of
create tablet and delete tablet operations.
The addition of monitoring items will aid in historical issue
tracking and analysis, as well as facilitate the configuration
of monitoring alarms.

Reviewed-on: http://gerrit.cloudera.org:8080/21316
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit b72fc6255a77418ef87fc5f07476528b027c6f99)

This is the commit message #7:

[CmakeLists.txt] Fix typo

Reviewed-on: http://gerrit.cloudera.org:8080/21395
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Wang Xixu <14...@qq.com>
Tested-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit afc3da3ad62dd53d180ef830b2c8d14e2aaf025c)

This is the commit message #8:

KUDU-3216 fix flakiness in LeadershipChangeOnTskGeneration

Before this patch, the LeadershipChangeOnTskGeneration scenario from
CatalogManagerTskITest would fail once in about 50 runs, DEBUG build.

With this patch, the test scenario hasn't had a single failure in
about 300 runs, DEBUG build.

Reviewed-on: http://gerrit.cloudera.org:8080/21397
Reviewed-by: Wang Xixu <14...@qq.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit ca56ee56eb14ea4e91e0ec20b5b8cd857b60423c)

This is the commit message #9:

[tablet] update the severity level of some tablet metrics

The motivation for this update was a request to provide information
on the number of rows returned by scanners run against a particular
tablet. That's to be on par with the following tablet metrics of the
MetricLevel::kInfo severity level:
  * rows_inserted
  * rows_updated
  * rows_upserted
  * rows_deleted

I also took the liberty of updating the level of some other tablet
metrics to make their severity level more consistent with the rest
of tablet metrics that have similar semantics.

Reviewed-on: http://gerrit.cloudera.org:8080/21384
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 35716499d850ed594ea93255efa84708c3d65537)

This is the commit message #10:

[master] fix race in auto leader rebalancing

It turned out that auto leader rebalancing task wasn't explicitly
shutdown upon shutting down catalog manager.  That lead to race
conditions as reported by TSAN, at least in test scenarios (see below).
This patch addresses the issue.

  WARNING: ThreadSanitizer: data race (pid=23827)
    Write of size 1 at 0x7b4000008208 by main thread:
      #0 AnnotateRWLockDestroy thirdparty/src/llvm-11.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interface_ann.cpp:264 (auto_rebalancer-test+0x33575e)
      #1 kudu::rw_spinlock::~rw_spinlock() src/kudu/util/locks.h:89:5 (libmaster.so+0x359376)
      #2 kudu::master::TSManager::~TSManager() src/kudu/master/ts_manager.cc:108:1 (libmaster.so+0x4ad201)
      #3 kudu::master::TSManager::~TSManager() src/kudu/master/ts_manager.cc:107:25 (libmaster.so+0x4ad229)
      #4 std::__1::default_delete<kudu::master::TSManager>::operator()(kudu::master::TSManager*) const thirdparty/installed/tsan/include/c++/v1/memory:2262:5 (libmaster.so+0x407ce7)
      #5 std::__1::unique_ptr<kudu::master::TSManager, std::__1::default_delete<kudu::master::TSManager> >::reset(kudu::master::TSManager*) thirdparty/installed/tsan/include/c++/v1/memory:2517:7 (libmaster.so+0x40157d)
      #6 std::__1::unique_ptr<kudu::master::TSManager, std::__1::default_delete<kudu::master::TSManager> >::~unique_ptr() thirdparty/installed/tsan/include/c++/v1/memory:2471:19 (libmaster.so+0x4015eb)
      #7 kudu::master::Master::~Master() src/kudu/master/master.cc:263:1 (libmaster.so+0x3f7a4a)
      #8 kudu::master::Master::~Master() src/kudu/master/master.cc:261:19 (libmaster.so+0x3f7dc9)
      #9 std::__1::default_delete<kudu::master::Master>::operator()(kudu::master::Master*) const thirdparty/installed/tsan/include/c++/v1/memory:2262:5 (libmaster.so+0x435627)
      #10 std::__1::unique_ptr<kudu::master::Master, std::__1::default_delete<kudu::master::Master> >::reset(kudu::master::Master*) thirdparty/installed/tsan/include/c++/v1/memory:2517:7 (libmaster.so+0x42e6ed)
      #11 kudu::master::MiniMaster::Shutdown() src/kudu/master/mini_master.cc:120:13 (libmaster.so+0x4c2612)
    ...
    Previous atomic write of size 4 at 0x7b4000008208 by thread T439 (mutexes: write M1141235379631443968):
      #0 __tsan_atomic32_compare_exchange_strong thirdparty/src/llvm-11.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp:780 (auto_rebalancer-test+0x33eb60)
      #1 base::subtle::Release_CompareAndSwap(int volatile*, int, int) /src/kudu/gutil/atomicops-internals-tsan.h:88:3 (libmaster.so+0x2e2b34)
      #2 kudu::rw_semaphore::unlock_shared() src/kudu/util/rw_semaphore.h:91:19 (libmaster.so+0x2e29c8)
      #3 kudu::rw_spinlock::unlock_shared() src/kudu/util/locks.h:99:10 (libmaster.so+0x2e28ef)
      #4 std::__1::shared_lock<kudu::rw_spinlock>::~shared_lock() /thirdparty/installed/tsan/include/c++/v1/shared_mutex:369:19 (libmaster.so+0x2e23e0)
      #5 kudu::master::TSManager::GetAllDescriptors(std::__1::vector<std::__1::shared_ptr<kudu::master::TSDescriptor>, std::__1::allocator<std::__1::shared_ptr<kudu::master::TSDescriptor> > >*) const src/kudu/master/ts_manager.cc:206:1 (libmaster.so+0x4adeb6)
      #6 kudu::master::AutoLeaderRebalancerTask::RunLeaderRebalancer() src/kudu/master/auto_leader_rebalancer.cc:405:16 (libmaster.so+0x2fb51b)
      #7 kudu::master::AutoLeaderRebalancerTask::RunLoop() src/kudu/master/auto_leader_rebalancer.cc:445:7 (libmaster.so+0x2fbaa9)

This is a follow-up to 10efaf2c77dfe5e4474505e0267c583c011703be.

Reviewed-on: http://gerrit.cloudera.org:8080/21417
Reviewed-by: Wang Xixu <14...@qq.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
(cherry picked from commit 5fccfbc2bda0d017d283cbefcb3cb8e4b026c8e9)

This is the commit message #11:

KUDU-3568 Fix compaction budgeting test by setting memory hard limit

TestRowSetCompactionSkipWithBudgetingConstraints can fail if the
memory on node running the test is high. It happens because the test
generates deltas of size worth a few MBs that is multiplied with a
preset factor to ensure the result (i.e. memory required for rowset
compaction completion) is of high value of the order of 200 GB per
rowset.

Even though nodes running the test generally don't have so much
physical memory, it is still possible to end up with high memory nodes.
On such nodes, the test might fail.

The patch fixes that problem by deterministically ensuring that
compaction memory requirement is always higher than the memory hard
limit. It does that by doing the following:
1. Move out the budgeting compaction tests out in a separate binary.
2. This gives flexibility to set the memory hard limit as per test
   needs. It is important to node that once a memory hard limit is
   set, it remains the same for all tests executed through
   binary lifecycle.
3. Set the hard memory limit to 1 GB which is enough to handle compaction
   requirements for TestRowSetCompactionProceedWithNoBudgetingConstraints.
   For TestRowSetCompactionSkipWithBudgetingConstraints, it is not
   enough because we set the delta memory factor high to exceed 1 GB.
   Both the test are now expected to succeed deterministically.

Reviewed-on: http://gerrit.cloudera.org:8080/21416
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit b607633fd3c2b676fbd2cbe57c44bddf818dc457)

This is the commit message #12:

[tablet] fix race accessing OpState's start time

This patch addresses a race reported by TSAN with traces like below:

WARNING: ThreadSanitizer: data race (pid=11024)
  Write of size 8 at 0x7b580011f260 by thread T174:
    #0 kudu::tablet::OpState::set_start_time(kudu::MonoTime) src/kudu/tablet/ops/op.h:274:58
    #1 kudu::tablet::WriteOp::Start() src/kudu/tablet/ops/write_op.cc:273:11
    #2 kudu::tablet::OpDriver::Prepare() src/kudu/tablet/ops/op_driver.cc:329:7
    #3 kudu::tablet::OpDriver::PrepareTask() src/kudu/tablet/ops/op_driver.cc:249:31
    ...

  Previous read of size 8 at 0x7b580011f260 by thread T5 (mutexes: write M835553159786377312):
    #0 kudu::tablet::OpState::start_time() const src/kudu/tablet/ops/op.h:272:40
    #1 kudu::tablet::WriteOp::ToString() const src/kudu/tablet/ops/write_op.cc:378:36
    #2 kudu::tablet::OpDriver::ToStringUnlocked() const src/kudu/tablet/ops/op_driver.cc:209:23
    #3 kudu::tablet::OpDriver::ToString() const src/kudu/tablet/ops/op_driver.cc:203:10
    #4 kudu::tablet::TabletReplica::GetInFlightOps(...) const src/kudu/tablet/tablet_replica.cc:728:41
    #5 kudu::tserver::TabletServerPathHandlers::HandleTransactionsPage(...) src/kudu/tserver/tserver_path_handlers.cc:286:14
    ...

Reviewed-on: http://gerrit.cloudera.org:8080/21427
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit feaf1daf56895c921fd08917334ce31d81f8b3e4)

This is the commit message #13:

[common] switch from unique_lock to lock_guard

To simplify working with STL synchronization primitives, this patch
changes from std::unique_lock to std::lock_guard where appropriate.
In addition, IWYU and ClangTidy's feedback has been addressed.

Reviewed-on: http://gerrit.cloudera.org:8080/21414
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit a3ed48d932d203e9310cca396e5530d6ed6eaa87)

This is the commit message #14:

[common] get rid of MutexLock

Since contemporary STL library provides both std::lock_guard and
std::unique_lock, there is no need to keep MutexLock.

Reviewed-on: http://gerrit.cloudera.org:8080/21415
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit eb0a41fdb0642baa61a58f925bb82157330abe7a)

This is the commit message #15:

[security-flags-itest] Fix missing command line flags

It is a known phenomenon, that static libraries won't be included into
an executable if there are no usage for any function or variable[1].
This means the initialization routines in the library won't be executed,
even if these initialization routines have side effects, such as
registering the variable in the gflags ecosystem. As a result, the
CheckRpcAuthnFlagsGroupValidator test failed because
"rpc_authentication" flag was not registered properly. To solve this
issue, a command line variable check is added, so now the library will
be used in the executable and the initialization routines will be
executed.

[1] https://stackoverflow.com/questions/1229430/how-do-i-prevent-my-unused-global-variables-being-compiled-out-of-my-static-li

Reviewed-on: http://gerrit.cloudera.org:8080/21399
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 46c4cb1c2906a77f700509d02813a15dbf919927)

This is the commit message #16:

[alter_table-test] Increase assertion timeout

On ubuntu 22.04 release build, AlterReplicationFactorWhileWriting test
failed with timeout. So timeout was increased to 60 seconds.

Reviewed-on: http://gerrit.cloudera.org:8080/21347
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 49d2bc9ed51307cd9b258681cb64a92ef1cf07a5)

This is the commit message #17:

Allow creating a table with empty range partition

Currently, when creating a table without setting range partition,
it will create an unbounded partition defaultly. In some cases,
this method is not suitable. For example, the user wants to create
a table with empty partition, and add a new partition daily to
import the data into Kudu. Besides, copying a empty partition table
to another cluster will create an unbounded partition table when
using the CLI command 'kudu table copy'. It changes the orginal
table structure.
Therefore, it is better to support to create a table with empty
partition, that is without any partitions.

Reviewed-on: http://gerrit.cloudera.org:8080/21328
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit 247535e5ee93f6219c7ba00a1051524b2079411e)

This is the commit message #18:

Leader rebalance ignores soft deleted tables

Soft deleted tables no longer provide read/write service.
Therefore it is not needed to do leader rebalance for soft
deleted tables, which may take a long time.
This patch provides a configuration
'leader_rebalancing_filter_soft_deleted_tables' to decide
whether to ignore soft deleted tables when leader rebalancing.

Reviewed-on: http://gerrit.cloudera.org:8080/21411
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit d7fb77f4cfbf6d638c6d11009ce3728ae30e01e3)

This is the commit message #19:

[metrics] Add tablet level metrics for alter schema op time

Add tablet-level statistics to track the time consumption of
alter schema operations.

The addition of monitoring items will aid in historical issue
tracking and analysis, as well as facilitate the configuration
of monitoring alarms.

Reviewed-on: http://gerrit.cloudera.org:8080/21300
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
(cherry picked from commit c2d25d5f57d102d9ad9869eaf208d035a22e18aa)

This is the commit message #20:

[metrics] Add tablet level metrics for scans op time

We currently have monitoring in place for scan data volume and
slow scans, but we are still lacking monitoring data for scan
request timings.

In this patch, I have added monitoring for scan request timings at
the tablet level to assist us in pinpointing specific scenarios of
high CPU usage during scanning operations.

Reviewed-on: http://gerrit.cloudera.org:8080/21291
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 6d6364d19d287d8effb604b6ab11dfdff5db794e)

Change-Id: Ia8a195f68ba5db33fa1e48d5f208b887f577faf5
---
M CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table_creator-internal.h
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
M src/kudu/integration-tests/security-flags-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/master/auto_leader_rebalancer-test.cc
M src/kudu/master/auto_leader_rebalancer.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/rpc/rpcz_store.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/rpc/service_queue.h
M src/kudu/security/tls_context.cc
M src/kudu/server/diagnostics_log.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/CMakeLists.txt
A src/kudu/tablet/compaction-highmem-test.cc
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/ops/op.h
M src/kudu/tablet/ops/write_op.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_metrics.cc
M src/kudu/tablet/tablet_metrics.h
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/table_scanner.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_service.cc
M src/kudu/tserver/tablet_copy_service.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/util/CMakeLists.txt
M src/kudu/util/async_logger.cc
M src/kudu/util/async_logger.h
M src/kudu/util/barrier.h
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
M src/kudu/util/cloud/instance_detector.cc
M src/kudu/util/countdown_latch.h
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_synthetic_delay.cc
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/mutex.h
M src/kudu/util/pstack_watcher.cc
M src/kudu/util/rwc_lock.cc
M src/kudu/util/stopwatch.h
M src/kudu/util/test_graph.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
M src/kudu/util/trace_metrics.h
77 files changed, 1,081 insertions(+), 486 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/21772/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8a195f68ba5db33fa1e48d5f208b887f577faf5
Gerrit-Change-Number: 21772
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR](branch-1.17.x) Squash cherry-picked commits #9 This is a combination of 20 commits.

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21772 )

Change subject: Squash cherry-picked commits #9 This is a combination of 20 commits.
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/488/


-- 
To view, visit http://gerrit.cloudera.org:8080/21772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a195f68ba5db33fa1e48d5f208b887f577faf5
Gerrit-Change-Number: 21772
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Sep 2024 22:51:55 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) Squash cherry-picked commits #9 This is a combination of 20 commits.

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has abandoned this change. ( http://gerrit.cloudera.org:8080/21772 )

Change subject: Squash cherry-picked commits #9 This is a combination of 20 commits.
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/21772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia8a195f68ba5db33fa1e48d5f208b887f577faf5
Gerrit-Change-Number: 21772
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR](branch-1.17.x) Squash cherry-picked commits #9 This is a combination of 20 commits.

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21772 )

Change subject: Squash cherry-picked commits #9 This is a combination of 20 commits.
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/488/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21772
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8a195f68ba5db33fa1e48d5f208b887f577faf5
Gerrit-Change-Number: 21772
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Sep 2024 17:40:14 +0000
Gerrit-HasComments: No