You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2020/08/15 15:30:58 UTC

[GitHub] [avro] kojiromike commented on a change in pull request #936: AVRO-2906: Traversal validation

kojiromike commented on a change in pull request #936:
URL: https://github.com/apache/avro/pull/936#discussion_r471003460



##########
File path: lang/py/avro/schema.py
##########
@@ -221,6 +232,18 @@ def to_json(self, names):
         """
         raise Exception("Must be implemented by subclasses.")
 
+    def validate(self, datum):

Review comment:
       Can this be an abstractmethod? If you don't want to do it in this PR I can make all these de-facto abstract methods official in a later batch change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org