You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/12 08:06:01 UTC
[GitHub] [fineract-cn-mobile] podorvanova opened a new pull request #113: FINCN-112: Update compile and target SDK versions of the app
podorvanova opened a new pull request #113:
URL: https://github.com/apache/fineract-cn-mobile/pull/113
Fixes #112
The issue said "Android SDK version 27 must be changed to 28", but the project's SDK version was already 28. After talking to @xurror, we had an agreement to changed it it to 29.
Android SDK changing was successful. There were no errors or new warnings after project building.
- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
- [ ] If you have multiple commits please combine them into one commit by squashing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] xurror commented on pull request #113: FINCN-112: Update compile and target SDK versions of the app
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #113:
URL: https://github.com/apache/fineract-cn-mobile/pull/113#issuecomment-707108558
Congratulations on your first PR.
Seems travis is not accepting SDK licenses. Probably need to change some few things in travis.yml to make this work. I'm not much into android stuff but if you have tested this locally and it worked fine then it should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-mobile] podorvanova commented on pull request #113: FINCN-112: Update compile and target SDK versions of the app
Posted by GitBox <gi...@apache.org>.
podorvanova commented on pull request #113:
URL: https://github.com/apache/fineract-cn-mobile/pull/113#issuecomment-707015028
The build failed because license for package Android SDK Build-Tools 29.0.3 was not accepted. What should I do about this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org