You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/06/04 15:50:19 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #7646: Compile example column names

villebro opened a new pull request #7646: Compile example column names
URL: https://github.com/apache/incubator-superset/pull/7646
 
 
   ### CATEGORY
   
   - [x] Bug Fix
   
   ### SUMMARY
   This PR makes sure that column names are conditionally quoted. Without compilation some examples don't work on Postgres, namely the ones with metrics referencing uppercase columns.
   
   ### TEST PLAN
   Tested locally.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixe #6009
   
   ### REVIEWERS
   @dostiharise @andy-clapson @trrahul @michaldul
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org