You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Radim Kolar (JIRA)" <ji...@apache.org> on 2012/11/22 15:54:58 UTC
[jira] [Commented] (HADOOP-8698) Do not call unneceseary
setConf(null) in Configured constructor
[ https://issues.apache.org/jira/browse/HADOOP-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502802#comment-13502802 ]
Radim Kolar commented on HADOOP-8698:
-------------------------------------
any progress with review? Its really simple patch.
> Do not call unneceseary setConf(null) in Configured constructor
> ---------------------------------------------------------------
>
> Key: HADOOP-8698
> URL: https://issues.apache.org/jira/browse/HADOOP-8698
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 0.23.3, 3.0.0
> Reporter: Radim Kolar
> Priority: Minor
> Fix For: 0.24.0, 3.0.0
>
> Attachments: setconf-null.txt
>
>
> no-arg constructor of /org/apache/hadoop/conf/Configured calls setConf(null). This is unnecessary and it increases complexity of setConf() code because you have to check for not null object reference before using it. Under normal conditions setConf() is never called with null reference, so not null check is unnecessary.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira