[GitHub] sanha commented on a change in pull request #4: [NEMO-28] Javadoc and Travis

[GitBox <gi...@apache.org>]

sanha commented on a change in pull request #4: [NEMO-28] Javadoc and Travis
URL: https://github.com/apache/incubator-nemo/pull/4#discussion_r172507593
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/test/ArgBuilder.java
 ##########
 @@ -19,12 +19,14 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.StringJoiner;
-import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 /**
  * Argument builder.
  */
 public final class ArgBuilder {
+  private static final List<List<String>> DEFAULT_ARGS = Arrays.asList(Arrays.asList("-executor_json",
 
 Review comment:
   Is this needed to override the json path?
   If so, can't we bind parameter through Tang instead of this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services