You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Paul Isaychuk (JIRA)" <ji...@apache.org> on 2016/02/05 12:44:39 UTC
[jira] [Updated] (FALCON-1819) Improve test class entity cleanup
logic
[ https://issues.apache.org/jira/browse/FALCON-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Isaychuk updated FALCON-1819:
----------------------------------
Description:
>From discussion with Pragya Mittal:
To got cleaned up, entity should have a name of form like: <prefix> \[entity name itself\]. Where prefix is either test class name or <'A'>+test class name hash code (depending on is_deprecate property from Merlin.properties).
If entity name is something else, it wouldn't be removed.
But seems that in case of FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting deleted not bacause of that.
As another user (root) is involved in test case (by submitting feed that belongs to this another user), we don't see that feed in listing feeds as test user (which is used by default to list and remove entities). Makes sense?
So we need to improve clean up logic. Do we need to create separate jira for that? (it might be better then to squash it with new test)
was:
>From discussion with Pragya Mittal:
To be deleted, entity name should be of form like: <prefix> \[entity name itself\]. Where prefix is either test class name or <'A'>+test class name hash code (depending on is_deprecate property from Merlin.properties).
If entity name is something else, it wouldn't be removed.
But seems that in case of FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting deleted not bacause of that.
As another user (root) is involved in test case (by submitting feed that belongs to this another user), we don't see that feed in listing feeds as test user (which is used by default to list and remove entities). Makes sense?
So we need to improve clean up logic. Do we need to create separate jira for that? (it might be better then to squash it with new test)
> Improve test class entity cleanup logic
> ---------------------------------------
>
> Key: FALCON-1819
> URL: https://issues.apache.org/jira/browse/FALCON-1819
> Project: Falcon
> Issue Type: Bug
> Components: merlin
> Affects Versions: 0.7
> Reporter: Paul Isaychuk
> Assignee: Paul Isaychuk
> Fix For: trunk
>
>
> From discussion with Pragya Mittal:
> To got cleaned up, entity should have a name of form like: <prefix> \[entity name itself\]. Where prefix is either test class name or <'A'>+test class name hash code (depending on is_deprecate property from Merlin.properties).
> If entity name is something else, it wouldn't be removed.
> But seems that in case of FeedSubmitAndScheduleTest#snsDiffFeedDiffUserSameCluster feed is not getting deleted not bacause of that.
> As another user (root) is involved in test case (by submitting feed that belongs to this another user), we don't see that feed in listing feeds as test user (which is used by default to list and remove entities). Makes sense?
> So we need to improve clean up logic. Do we need to create separate jira for that? (it might be better then to squash it with new test)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)