You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/04/21 22:18:59 UTC
[GitHub] [superset] justinpark opened a new pull request, #23778: fix(chart): scrollbar keep flusing on and off
justinpark opened a new pull request, #23778:
URL: https://github.com/apache/superset/pull/23778
### SUMMARY
This bug introduced by #20282
After resize target element has scrollbars, the chart keeps flushing scrollbars on and oft.
It because keeps re-calculate the element's size due to the content size is different with/without scrollbars.
This commit replaces the resize observe element with the parent element (which has no scrollbars) and then calculate the chartPanel element from onResize handler.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://user-images.githubusercontent.com/1392866/233742823-90c0ec40-997f-4341-8560-40a7e7ff68fe.mov
Before:
https://user-images.githubusercontent.com/1392866/233742847-88d0bb9c-4abd-4334-8303-6c8c014e7ffd.mov
### TESTING INSTRUCTIONS
Open a chart explore
Resize window width smaller
check the chart scroll
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #23778: fix(chart): scrollbar keep flusing on and off
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23778:
URL: https://github.com/apache/superset/pull/23778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #23778: fix(chart): scrollbar keep flusing on and off
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #23778:
URL: https://github.com/apache/superset/pull/23778#issuecomment-1520715920
> I fixed the Frontend CI error [here](https://github.com/apache/superset/pull/23784/files#diff-73c6424e4e29bec177cd5c97f785865635844097ab9a2a1e2f94408f6a2cdeec).
@michael-s-molina the CI error came from [here](https://github.com/apache/superset/pull/23778/files#diff-58ba2786e06a5568043a6f7c00d255688791e3c7265a485aed8576cb1d094559L81) and I already fixed with replacing mock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #23778: fix(chart): scrollbar keep flusing on and off
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #23778:
URL: https://github.com/apache/superset/pull/23778#issuecomment-1552117981
Hi @justinpark we're seeing some regression with this ticket when running reports, or viewing a chart in standalone mode. Do you have time to put up a quick fix for this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23778: fix(chart): scrollbar keep flusing on and off
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23778:
URL: https://github.com/apache/superset/pull/23778#issuecomment-1520599489
## [Codecov](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23778](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a561a0) into [master](https://codecov.io/gh/apache/superset/commit/4b3e507e8b22b2d25e9a79c1feb03fceaefbd464?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b3e507) will **increase** coverage by `0.02%`.
> The diff coverage is `80.76%`.
> :exclamation: Current head 3a561a0 differs from pull request most recent head fee6195. Consider uploading reports for the commit fee6195 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23778 +/- ##
==========================================
+ Coverage 67.87% 67.89% +0.02%
==========================================
Files 1925 1937 +12
Lines 74389 74922 +533
Branches 8108 8142 +34
==========================================
+ Hits 50494 50872 +378
- Misses 21818 21957 +139
- Partials 2077 2093 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.21% <72.25%> (+0.10%)` | :arrow_up: |
| postgres | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...chart-echarts/src/Timeseries/EchartsTimeseries.tsx](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy9FY2hhcnRzVGltZXNlcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `78.40% <42.85%> (-1.11%)` | :arrow_down: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `51.06% <50.00%> (-0.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/ocient.py](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29jaWVudC5weQ==) | `57.28% <57.28%> (ø)` | |
| [...nts/ExploreChartPanel/useResizeDectorByObserver.ts](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC91c2VSZXNpemVEZWN0b3JCeU9ic2VydmVyLnRz) | `62.50% <62.50%> (ø)` | |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `92.85% <70.00%> (-2.60%)` | :arrow_down: |
| [...-frontend/src/pages/RowLevelSecurityList/index.tsx](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL1Jvd0xldmVsU2VjdXJpdHlMaXN0L2luZGV4LnRzeA==) | `72.54% <72.54%> (ø)` | |
| [...rontend/src/features/rls/RowLevelSecurityModal.tsx](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL3Jscy9Sb3dMZXZlbFNlY3VyaXR5TW9kYWwudHN4) | `73.39% <73.39%> (ø)` | |
| [...uperset/row\_level\_security/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | `87.50% <87.50%> (ø)` | |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `89.71% <90.90%> (+0.91%)` | :arrow_up: |
| ... and [12 more](https://codecov.io/gh/apache/superset/pull/23778?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [22 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23778/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #23778: fix(chart): scrollbar keep flusing on and off
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #23778:
URL: https://github.com/apache/superset/pull/23778#issuecomment-1519124157
I fixed the Frontend CI error [here](https://github.com/apache/superset/pull/23784/files#diff-73c6424e4e29bec177cd5c97f785865635844097ab9a2a1e2f94408f6a2cdeec).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org