[GitHub] [flink] vthinkxie commented on a change in pull request #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex

[GitBox <gi...@apache.org>]

vthinkxie commented on a change in pull request #9601: [FLINK-13894][web]Web Ui add log url for subtask of vertex
URL: https://github.com/apache/flink/pull/9601#discussion_r336870534
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/job/overview/subtasks/job-overview-drawer-subtasks.component.html
 ##########
 @@ -69,9 +70,22 @@
       <td>{{ task["start_time"] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
       <td>{{ task.duration | humanizeDuration }}</td>
       <td>{{ task["end-time"] | humanizeDate: 'yyyy-MM-dd HH:mm:ss' }}</td>
-      <td nzRight="0px">
+      <td nzRight="50px">
         <flink-job-badge [state]="task.status"></flink-job-badge>
       </td>
+      <td nzRight="0px">
+        <nz-dropdown [nzPlacement]="'bottomRight'">
+          <span nz-dropdown><i nz-icon nzType="ellipsis" nzTheme="outline"></i></span>
+              <ul nz-menu nzSelectable>
+                <li nz-menu-item>
+              <span *ngIf="!task['taskmanager-id'] || task['taskmanager-id'] === '(unassigned)'; else hrefTpl">-</span>
+              <ng-template #hrefTpl>
+                <a [routerLink]="['/task-manager',task['taskmanager-id'],'logs']" target="_blank">Taskamanger Log</a>
 
 Review comment:
   ```suggestion
                   <a [routerLink]="['/task-manager',task['taskmanager-id'],'logs']" target="_blank">View taskmanger log</a>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services