You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/13 19:03:18 UTC

[GitHub] [activemq-artemis] jbertram opened a new pull request #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP

jbertram opened a new pull request #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP

Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018#issuecomment-605369813
 
 
   i think you can merge @jbertram its been 2 weeks an no other comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018#issuecomment-598875783
 
 
   How are we differentiating if it should be anycast or multicast queue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] jbertram commented on issue #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP

Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #3018: ARTEMIS-2649 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018#issuecomment-598880917
 
 
   I added a blurb to [the documentation](https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/stomp.md#routing-semantics) not too long ago describing how control routing semantics with STOMP.
   
   As far as the code goes, a `RoutingType` is passed to the `autoCreateDestinationIfPossible` method which is based on the frame's header or destination prefix. If that is `null` then it uses the default value specified in the address-settings. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] jbertram edited a comment on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP

Posted by GitBox <gi...@apache.org>.
jbertram edited a comment on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018#issuecomment-598880917
 
 
   I added a blurb to [the documentation](https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/stomp.md#routing-semantics) not too long ago describing how to control routing semantics with STOMP.
   
   As far as the code goes, a `RoutingType` is passed to the `autoCreateDestinationIfPossible` method which is based on the frame's header or destination prefix. If that is `null` then it uses the default value specified in the address-settings. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3018: ARTEMIS-2655 support auto-creation w/FQQN & STOMP
URL: https://github.com/apache/activemq-artemis/pull/3018#issuecomment-598891701
 
 
   Thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services