You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "e-galan (via GitHub)" <gi...@apache.org> on 2024/05/16 13:08:29 UTC
[PR] Reroute AutoML operator links to Google Translation links [airflow]
e-galan opened a new pull request, #39668:
URL: https://github.com/apache/airflow/pull/39668
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Update deprecated AutoML operators with new links. Due to its future deprecation AutoML's URLs have been divided between Google Translation and Vertex AI services. This PR updates the operators that are going to be used only with Google Translation services.
I opted to create a new module `airflow/providers/google/cloud/links/translate.py` and put the new links there instead of updating the existing AutoML links in `airflow/providers/google/cloud/links/automl.py` because:
- The links are leading to Google Translation URLs anyway;
- Corresponding AutoML URLs are no longer accessible and will be deprecated in the future;
- There is no module for the Google Translation links yet even though Google Translation operators exist.
This PR is dependent on and should not be merged before https://github.com/apache/airflow/pull/38673 .
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reroute AutoML operator links to Google Translation links [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #39668:
URL: https://github.com/apache/airflow/pull/39668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reroute AutoML operator links to Google Translation links [airflow]
Posted by "e-galan (via GitHub)" <gi...@apache.org>.
e-galan commented on code in PR #39668:
URL: https://github.com/apache/airflow/pull/39668#discussion_r1608761585
##########
airflow/providers/google/cloud/links/translate.py:
##########
Review Comment:
Hey @Taragolis , I added the tests, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reroute AutoML operator links to Google Translation links [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #39668:
URL: https://github.com/apache/airflow/pull/39668#issuecomment-2124316612
Hi @potiuk !
Can you please merge changes from here? I guess they were reviewed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reroute AutoML operator links to Google Translation links [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #39668:
URL: https://github.com/apache/airflow/pull/39668#discussion_r1604871256
##########
airflow/providers/google/cloud/links/automl.py:
##########
@@ -65,6 +75,13 @@ def persist(
)
+@deprecated(
+ reason=(
+ "Class `AutoMLDatasetListLink` has been deprecated and will be removed after 31.12.2024."
Review Comment:
```suggestion
"Class `AutoMLDatasetListLink` has been deprecated and will be removed after 31.12.2024. "
```
##########
airflow/providers/google/cloud/links/automl.py:
##########
@@ -87,6 +104,13 @@ def persist(
)
+@deprecated(
+ reason=(
+ "Class `AutoMLModelLink` has been deprecated and will be removed after 31.12.2024."
Review Comment:
```suggestion
"Class `AutoMLModelLink` has been deprecated and will be removed after 31.12.2024. "
```
##########
airflow/providers/google/cloud/links/translate.py:
##########
Review Comment:
Required to add tests into the `tests/providers/google/cloud/links/test_translate.py`
##########
airflow/providers/google/cloud/links/automl.py:
##########
@@ -114,6 +138,13 @@ def persist(
)
+@deprecated(
+ reason=(
+ "Class `AutoMLModelTrainLink` has been deprecated and will be removed after 31.12.2024."
Review Comment:
```suggestion
"Class `AutoMLModelTrainLink` has been deprecated and will be removed after 31.12.2024. "
```
##########
airflow/providers/google/cloud/links/automl.py:
##########
@@ -138,6 +169,13 @@ def persist(
)
+@deprecated(
+ reason=(
+ "Class `AutoMLModelPredictLink` has been deprecated and will be removed after 31.12.2024."
Review Comment:
```suggestion
"Class `AutoMLModelPredictLink` has been deprecated and will be removed after 31.12.2024. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org