[GitHub] srowen commented on a change in pull request #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23589: [SPARK-26351][mllib]Update doc and minor correction in the mllib evaluation metrics
URL: https://github.com/apache/spark/pull/23589#discussion_r249247842
 
 

 ##########
 File path: docs/mllib-evaluation-metrics.md
 ##########
 @@ -439,21 +439,21 @@ $$rel_D(r) = \begin{cases}1 & \text{if $r \in D$}, \\ 0 & \text{otherwise}.\end{
         Precision at k
       </td>
       <td>
-        $p(k)=\frac{1}{M} \sum_{i=0}^{M-1} {\frac{1}{k} \sum_{j=0}^{\text{min}(\left|D\right|, k) - 1} rel_{D_i}(R_i(j))}$
+        $p(k)=\frac{1}{M} \sum_{i=0}^{M-1} {\frac{1}{k} \sum_{j=0}^{\text{min}(\left|R_i\right|, k) - 1} rel_{D_i}(R_i(j))}$
 
 Review comment:
   Although we usually have k <= |D| and k <= |R_i|, I agree that this is technically what must have been meant. How about using Q here instead of |R_i|? it was already used in the following formula. You can change both, sure, either way, as long as they're consistent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org