You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/27 17:34:19 UTC
[GitHub] [airflow] turbaszek opened a new pull request #7908: Remove
GKEStartPodOperator when backporting
turbaszek opened a new pull request #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.90% -0.17%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
+ Hits 39205 39270 +65
- Misses 5823 5917 +94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `89.47% <0.00%> (-4.65%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.58% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [airflow/models/variable.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdmFyaWFibGUucHk=) | `93.33% <0.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...458b6ba](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605677732
Hi. I thought about it longer and I think it should not be a problem to use the operators from airflow.contrib in Airflow 1.10. That way, we won't have to have a separate example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.90% -0.17%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
+ Hits 39205 39270 +65
- Misses 5823 5917 +94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `89.47% <0.00%> (-4.65%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.58% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [airflow/models/variable.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdmFyaWFibGUucHk=) | `93.33% <0.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...458b6ba](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.90% -0.17%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
+ Hits 39205 39270 +65
- Misses 5823 5917 +94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `89.47% <0.00%> (-4.65%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.58% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [airflow/models/variable.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdmFyaWFibGUucHk=) | `93.33% <0.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...458b6ba](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.41% -0.66%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
- Hits 39205 39049 -156
- Misses 5823 6138 +315
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...79d17d7](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.41% -0.66%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
- Hits 39205 39049 -156
- Misses 5823 6138 +315
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...79d17d7](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7908:
Remove GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#discussion_r399772049
##########
File path: tests/conftest.py
##########
@@ -178,11 +178,14 @@ def pytest_configure(config):
"markers", "system(name): mark test to run with named system"
)
config.addinivalue_line(
- "markers", "long_running(name): mark test that run for a long time (many minutes)"
+ "markers", "long_running: mark test that run for a long time (many minutes)"
)
config.addinivalue_line(
"markers", "credential_file(name): mark tests that require credential file in CREDENTIALS_DIR"
)
+ config.addinivalue_line(
+ "markers", "master_only: mark tests that works only on Airflow 2.0 / master"
Review comment:
NIT: maybe we should name it 'airflow_2" or similar rather than master. There will be some period of time that we will still produce backport operators and airflow 2.0 will be already released (and won't be master then)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] turbaszek commented on a change in pull request #7908:
Remove GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#discussion_r399776966
##########
File path: tests/conftest.py
##########
@@ -178,11 +178,14 @@ def pytest_configure(config):
"markers", "system(name): mark test to run with named system"
)
config.addinivalue_line(
- "markers", "long_running(name): mark test that run for a long time (many minutes)"
+ "markers", "long_running: mark test that run for a long time (many minutes)"
)
config.addinivalue_line(
"markers", "credential_file(name): mark tests that require credential file in CREDENTIALS_DIR"
)
+ config.addinivalue_line(
+ "markers", "master_only: mark tests that works only on Airflow 2.0 / master"
Review comment:
Agree, done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.41% -0.66%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
- Hits 39205 39049 -156
- Misses 5823 6138 +315
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.25% <0.00%> (-72.50%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `47.82% <0.00%> (-52.18%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| ... and [33 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...79d17d7](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7908: Remove
GKEStartPodOperator when backporting
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7908: Remove GKEStartPodOperator when backporting
URL: https://github.com/apache/airflow/pull/7908#issuecomment-605609365
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=h1) Report
> Merging [#7908](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cc631e0cb67bd5cdd9ce4f3dedbb1ab611a00e9&el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7908 +/- ##
==========================================
- Coverage 87.06% 86.90% -0.17%
==========================================
Files 929 932 +3
Lines 45028 45187 +159
==========================================
+ Hits 39205 39270 +65
- Misses 5823 5917 +94
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ud/example\_dags/example\_kubernetes\_engine\_setup.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZW5naW5lX3NldHVwLnB5) | `100.00% <100.00%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `89.47% <0.00%> (-4.65%)` | :arrow_down: |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.58% <0.00%> (-0.12%)` | :arrow_down: |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| [airflow/models/variable.py](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdmFyaWFibGUucHk=) | `93.33% <0.00%> (ø)` | |
| ... and [21 more](https://codecov.io/gh/apache/airflow/pull/7908/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=footer). Last update [3cc631e...458b6ba](https://codecov.io/gh/apache/airflow/pull/7908?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services