You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "hamilton-earthscope (via GitHub)" <gi...@apache.org> on 2023/05/24 23:20:21 UTC
[GitHub] [tinkerpop] hamilton-earthscope opened a new pull request, #2076: (new) (gremlin-python) improve translation
hamilton-earthscope opened a new pull request, #2076:
URL: https://github.com/apache/tinkerpop/pull/2076
This MR improves the python `Translator` class in two ways:
- handle `TextP` predicates in addition to `P`
- handle quoting for subclasses of `str`
Tests have been added to verify the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2076: (new) (gremlin-python) improve translation
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076#issuecomment-1563801108
Note for merging: this change should get backported to 3.5-dev but 3.5-dev doesn't use snake case so there are some minor changes needed to do that. Also if we are backporting then it makes sense for the CHANGELOG entry to be 3.5-dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2076: (new) (gremlin-python) improve translation
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076#issuecomment-1569278783
Thanks for contributing another improvement. Looks good to me.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2076: (new) (gremlin-python) improve translation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076#issuecomment-1562358312
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2076?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2076](https://app.codecov.io/gh/apache/tinkerpop/pull/2076?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cce38da) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/f9394a4da0de5e98d5f0ec5817194c16cf236c0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f9394a4) will **decrease** coverage by `5.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2076 +/- ##
=============================================
- Coverage 69.59% 64.59% -5.00%
=============================================
Files 878 25 -853
Lines 42258 3802 -38456
Branches 5638 0 -5638
=============================================
- Hits 29410 2456 -26954
+ Misses 10869 1179 -9690
+ Partials 1979 167 -1812
```
[see 853 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2076/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #2076: (new) (gremlin-python) improve translation
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076#issuecomment-1569251868
LGTM, VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2076: (new) (gremlin-python) improve translation
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076#issuecomment-1563799746
Thanks again for contributing. I had a quick look and the changes look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer merged pull request #2076: (new) (gremlin-python) improve translation
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2076:
URL: https://github.com/apache/tinkerpop/pull/2076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org