[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29105: [SPARK-25075] Fix some complilation error scala 2.13 part 1

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #29105:
URL: https://github.com/apache/spark/pull/29105#discussion_r454486412



##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -653,7 +653,7 @@ private[spark] class SparkSubmit extends Logging {
       if (opt.value != null &&
           (deployMode & opt.deployMode) != 0 &&
           (clusterManager & opt.clusterManager) != 0) {
-        if (opt.clOption != null) { childArgs += (opt.clOption, opt.value) }
+        if (opt.clOption != null) { childArgs += opt.clOption += opt.value }

Review comment:
       We already make `core` module to pass Scala 2.13 compilation three days ago. Is this required?
   - https://github.com/apache/spark/commit/3ad4863673fc46080dda963be3055a3e554cfbc7
   
   cc @srowen 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org