[GitHub] [accumulo] milleruntime commented on issue #811: Missing tests in hadoop-mapreduce

[GitBox <gi...@apache.org>]

milleruntime commented on issue #811: Missing tests in hadoop-mapreduce
URL: https://github.com/apache/accumulo/issues/811#issuecomment-479533873
 
 
   More information because this may be a good task for newer developers. 
   
   The Map Reduce code in org.apache.accumulo.core.client.mapred and org.apache.accumulo.core.client.mapreduce was deprecated in 2.0 in favor of more maintainable code now in the hadoop-mapreduce package.  A fluent builder was added to the new code to make it easier to set all the properties on a map reduce job. So now a job can be configured in one line like this:
   <pre>
   AccumuloOutputFormat.configure().clientProperties(props).batchWriterOptions(bwConfig)
         .defaultTable(name).createTables(true) // disabled by default
         .simulationMode(true) // disabled by default
         .store(job);
   </pre>
   
   The tests from the old code were copied over to the new package in hadoop-mapreduce.  But there are tests missing for some of the options.  We want to have tests for all of the new builder methods for 2.0.  Tests can be added to existing ones in hadoop-mapreduce/src/test/java/org/apache/accumulo/hadoop or it may be better to have new unit tests that just test the fluent API directly.  
   
   Here are some more methods that are missing tests:
   - OutputFormatBuilder -> createTables
   - OutputFormatBuilder -> clientPropertiesPath

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services