You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by felixcheung <gi...@git.apache.org> on 2017/10/21 06:59:26 UTC

[GitHub] spark pull request #19538: [SPARK-20393][WEBU UI][BACKPORT-2.0] Strengthen S...

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19538#discussion_r146098560
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
    @@ -506,4 +510,33 @@ private[spark] object UIUtils extends Logging {
     
       def getTimeZoneOffset() : Int =
         TimeZone.getDefault().getOffset(System.currentTimeMillis()) / 1000 / 60
    +
    +  /**
    +  * Return the correct Href after checking if master is running in the
    +  * reverse proxy mode or not.
    +  */
    +  def makeHref(proxy: Boolean, id: String, origHref: String): String = {
    --- End diff --
    
    this is not in the 2.0 PR?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org