You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Ron Smeral <rs...@redhat.com> on 2014/10/27 14:31:36 UTC
Javadoc review
Hi,
I noticed some mistakes in Javadoc, which I wanted to fix, but then I
noticed some more, and it quickly turned into a complete review of
core/api javadoc.
So I issued https://github.com/apache/deltaspike/pull/10 .
It would be great if someone could have a look at it. The commit
describes most of the changes I did, which range from corrections of
simple typos up to complete logical restructuring of Javadoc in a few
classes.
In case the change makes sense and is accepted, I have a few more
javadoc fixes ready and I would continue reviewing the rest of the modules.
Thanks,
R.
--
Ron Smeral
JBoss Quality Engineer
Brno
Re: Javadoc review
Posted by Rafael Benevides <be...@redhat.com>.
Hi Ron!
I'll review it.
On 10/27/14 11:31, Ron Smeral wrote:
> Hi,
>
> I noticed some mistakes in Javadoc, which I wanted to fix, but then I
> noticed some more, and it quickly turned into a complete review of
> core/api javadoc.
> So I issued https://github.com/apache/deltaspike/pull/10 .
>
> It would be great if someone could have a look at it. The commit
> describes most of the changes I did, which range from corrections of
> simple typos up to complete logical restructuring of Javadoc in a few
> classes.
>
> In case the change makes sense and is accepted, I have a few more
> javadoc fixes ready and I would continue reviewing the rest of the
> modules.
>
> Thanks,
>
> R.
>
Re: Javadoc review
Posted by "John D. Ament" <jo...@gmail.com>.
Yes, please create a JIRA and rebase the commit to include the ticket #.
Then happiness shall go forth.
Thanks for the help Ron!
On Wed, Oct 29, 2014 at 9:29 PM, Rafael Benevides <be...@redhat.com>
wrote:
> +1 to file a DeltaSpike JIRA so everybody can track it
>
>
> On 10/29/14 17:42, Ron Smeral wrote:
>
>> Thanks for checking the PR! I'll continue the review soon.
>> How do I get this merged? Should I file an issue?
>>
>> On 27.10.2014 14:52, Rafael Benevides wrote:
>>
>>> Hi Ron,
>>>
>>> I did an overview look on it and I believe that these changes makes
>>> sense and are very welcome.
>>>
>>> On 10/27/14 11:31, Ron Smeral wrote:
>>>
>>>> Hi,
>>>>
>>>> I noticed some mistakes in Javadoc, which I wanted to fix, but then I
>>>> noticed some more, and it quickly turned into a complete review of core/api
>>>> javadoc.
>>>> So I issued https://github.com/apache/deltaspike/pull/10 .
>>>>
>>>> It would be great if someone could have a look at it. The commit
>>>> describes most of the changes I did, which range from corrections of simple
>>>> typos up to complete logical restructuring of Javadoc in a few classes.
>>>>
>>>> In case the change makes sense and is accepted, I have a few more
>>>> javadoc fixes ready and I would continue reviewing the rest of the modules.
>>>>
>>>> Thanks,
>>>>
>>>> R.
>>>>
>>>>
>>>
>>
>
Re: Javadoc review
Posted by Rafael Benevides <be...@redhat.com>.
+1 to file a DeltaSpike JIRA so everybody can track it
On 10/29/14 17:42, Ron Smeral wrote:
> Thanks for checking the PR! I'll continue the review soon.
> How do I get this merged? Should I file an issue?
>
> On 27.10.2014 14:52, Rafael Benevides wrote:
>> Hi Ron,
>>
>> I did an overview look on it and I believe that these changes makes
>> sense and are very welcome.
>>
>> On 10/27/14 11:31, Ron Smeral wrote:
>>> Hi,
>>>
>>> I noticed some mistakes in Javadoc, which I wanted to fix, but then
>>> I noticed some more, and it quickly turned into a complete review of
>>> core/api javadoc.
>>> So I issued https://github.com/apache/deltaspike/pull/10 .
>>>
>>> It would be great if someone could have a look at it. The commit
>>> describes most of the changes I did, which range from corrections of
>>> simple typos up to complete logical restructuring of Javadoc in a
>>> few classes.
>>>
>>> In case the change makes sense and is accepted, I have a few more
>>> javadoc fixes ready and I would continue reviewing the rest of the
>>> modules.
>>>
>>> Thanks,
>>>
>>> R.
>>>
>>
>
Re: Javadoc review
Posted by Ron Smeral <rs...@redhat.com>.
Thanks for checking the PR! I'll continue the review soon.
How do I get this merged? Should I file an issue?
On 27.10.2014 14:52, Rafael Benevides wrote:
> Hi Ron,
>
> I did an overview look on it and I believe that these changes makes
> sense and are very welcome.
>
> On 10/27/14 11:31, Ron Smeral wrote:
>> Hi,
>>
>> I noticed some mistakes in Javadoc, which I wanted to fix, but then I
>> noticed some more, and it quickly turned into a complete review of
>> core/api javadoc.
>> So I issued https://github.com/apache/deltaspike/pull/10 .
>>
>> It would be great if someone could have a look at it. The commit
>> describes most of the changes I did, which range from corrections of
>> simple typos up to complete logical restructuring of Javadoc in a few
>> classes.
>>
>> In case the change makes sense and is accepted, I have a few more
>> javadoc fixes ready and I would continue reviewing the rest of the
>> modules.
>>
>> Thanks,
>>
>> R.
>>
>
--
Ron Smeral
JBoss Quality Engineer
Brno
Re: Javadoc review
Posted by Rafael Benevides <be...@redhat.com>.
Hi Ron,
I did an overview look on it and I believe that these changes makes
sense and are very welcome.
On 10/27/14 11:31, Ron Smeral wrote:
> Hi,
>
> I noticed some mistakes in Javadoc, which I wanted to fix, but then I
> noticed some more, and it quickly turned into a complete review of
> core/api javadoc.
> So I issued https://github.com/apache/deltaspike/pull/10 .
>
> It would be great if someone could have a look at it. The commit
> describes most of the changes I did, which range from corrections of
> simple typos up to complete logical restructuring of Javadoc in a few
> classes.
>
> In case the change makes sense and is accepted, I have a few more
> javadoc fixes ready and I would continue reviewing the rest of the
> modules.
>
> Thanks,
>
> R.
>