You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/06/13 08:45:52 UTC
[Impala-ASF-CR](2.x) IMPALA-7315: fix test update with clear entries flag race
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13613
to review the following change.
Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race
......................................................................
IMPALA-7315: fix test_update_with_clear_entries_flag race
We need to wait for the subscriber to process the second update in order
to guarantee that the first update for that subscriber has been applied.
Otherwise there is a race window where the second subscriber may see the
older version of the statestore topic.
Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454
Reviewed-on: http://gerrit.cloudera.org:8080/10986
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/statestore/test_statestore.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/13613/1
--
To view, visit http://gerrit.cloudera.org:8080/13613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454
Gerrit-Change-Number: 13613
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7315: fix test update with clear entries flag race
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has abandoned this change. ( http://gerrit.cloudera.org:8080/13613 )
Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race
......................................................................
Abandoned
Sorry that I accidentally submit these patches. There're clean for cherry-pick so don't need for review.
--
To view, visit http://gerrit.cloudera.org:8080/13613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454
Gerrit-Change-Number: 13613
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7315: fix test update with clear entries flag race
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13613 )
Change subject: IMPALA-7315: fix test_update_with_clear_entries_flag race
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3598/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13613
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I2be2b61b6deb0228fbc5a242e43076beb8871454
Gerrit-Change-Number: 13613
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 09:16:28 +0000
Gerrit-HasComments: No