[GitHub] [ozone] k5342 commented on pull request #4048: HDDS-7596. Fix OM crash due to a corner case for FSO-enabled bucket

["k5342 (via GitHub)" <gi...@apache.org>]

k5342 commented on PR #4048:
URL: https://github.com/apache/ozone/pull/4048#issuecomment-1418894521

   > A test for this corner case with a mulitpart request with the fso zero-size null bucketInfo is needed.
   
   Thank you for your comments! Of course, I agree with you about adding some test cases.
   A test case is meant to be a test for `getOmClientResponse()`, right? Ideally, I think it's better for test coverage if we can put a test for `validateAndUpdateCache()`, but this function is a bit complex for unit testing, and I'm not sure how it can be reproduced as a unit testing to reach both `keyToDelete != null` and `usedBytesDiff == 0` (finally call `omBucketInfo = null`) because I think this might be a bug from some race conditions. What do you think about the granularity for testing?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org