You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2016/12/28 14:03:57 UTC
Review Request 55072: Non-editable properties should be handled for
add/delete host component
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55072/
-----------------------------------------------------------
Review request for Ambari and Andrii Tkach.
Bugs: AMBARI-19308
https://issues.apache.org/jira/browse/AMBARI-19308
Repository: ambari
Description
-------
Some properties updated after adding/deleting host component may be read-only. For example, user can edit nimbus.seeds value only before cluster install. Such cases should be handled.
Diffs
-----
ambari-web/app/controllers/main/host/details.js c38838f
ambari-web/app/messages.js a1b67e5
ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs a1f53ef
ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 295acc8
ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js 1aa46eb
ambari-web/test/controllers/main/host/details_test.js 024e994
Diff: https://reviews.apache.org/r/55072/diff/
Testing
-------
19993 tests complete (22 seconds)
153 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 55072: Non-editable properties should be handled
for add/delete host component
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55072/#review160240
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u0414\u0435\u043a. 28, 2016, 2:03 \u043f.\u043f., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55072/
> -----------------------------------------------------------
>
> (Updated \u0414\u0435\u043a. 28, 2016, 2:03 \u043f.\u043f.)
>
>
> Review request for Ambari and Andrii Tkach.
>
>
> Bugs: AMBARI-19308
> https://issues.apache.org/jira/browse/AMBARI-19308
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some properties updated after adding/deleting host component may be read-only. For example, user can edit nimbus.seeds value only before cluster install. Such cases should be handled.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host/details.js c38838f
> ambari-web/app/messages.js a1b67e5
> ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs a1f53ef
> ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 295acc8
> ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js 1aa46eb
> ambari-web/test/controllers/main/host/details_test.js 024e994
>
> Diff: https://reviews.apache.org/r/55072/diff/
>
>
> Testing
> -------
>
> 19993 tests complete (22 seconds)
> 153 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
Re: Review Request 55072: Non-editable properties should be handled
for add/delete host component
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55072/
-----------------------------------------------------------
(Updated \u0413\u0440\u0443. 28, 2016, 6:54 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
Review request for Ambari, Aleksandr Kovalenko and Andrii Tkach.
Bugs: AMBARI-19308
https://issues.apache.org/jira/browse/AMBARI-19308
Repository: ambari
Description
-------
Some properties updated after adding/deleting host component may be read-only. For example, user can edit nimbus.seeds value only before cluster install. Such cases should be handled.
Diffs (updated)
-----
ambari-web/app/controllers/main/host/details.js c38838f
ambari-web/app/messages.js a1b67e5
ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs a1f53ef
ambari-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 295acc8
ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js 1aa46eb
ambari-web/test/controllers/main/host/details_test.js 024e994
Diff: https://reviews.apache.org/r/55072/diff/
Testing (updated)
-------
19988 tests complete (23 seconds)
153 tests pending
Thanks,
Andriy Babiichuk